[Celestica/Seastone2] Load interface LEDs #9769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tested on a Celestica Seastone2 DX030 switch Testing scenarios: - Various QSFP ports in both normal and breakout config. - 100G and 40G link speed show different colors. - SFP1 port works. Signed-off-by: Christian Svensson <blue@cmd.nu>
bluecmd
requested review from
prgeor,
sujinmkang and
vdahiya12
as code owners
sujinmkang
approved these changes
Jan 19, 2022
sujinmkang
added
Request for 202012 Branch
Request for 202106 Branch
Request for 202111 Branch
judyjoseph
pushed a commit
that referenced
this pull request
Jan 23, 2022
Tested on a Celestica Seastone2 DX030 switch Testing scenarios: - Various QSFP ports in both normal and breakout config. - 100G and 40G link speed show different colors. - SFP1 port works. Signed-off-by: Christian Svensson <blue@cmd.nu>
qiluo-msft
pushed a commit
that referenced
this pull request
Jan 25, 2022
Tested on a Celestica Seastone2 DX030 switch Testing scenarios: - Various QSFP ports in both normal and breakout config. - 100G and 40G link speed show different colors. - SFP1 port works. Signed-off-by: Christian Svensson <blue@cmd.nu>
6 tasks
lukasstockner
added a commit
to genesiscloud/sonic-buildimage
that referenced
this pull request
Jun 13, 2022
Fixes sonic-net#10103. The LED init script that was added in sonic-net#9769 enables the port LEDs, but it turns out that the linkscan change combined with Broadcom SAI 6.0 breaks detection of port status on boot. Without the linkscan and sleep, the LED still work as expected, and the port status is correct again. Signed-off-by: Lukas Stockner <lstockner@genesiscloud.com>
lukasstockner
added a commit
to genesiscloud/sonic-buildimage
that referenced
this pull request
Mar 14, 2023
Fixes sonic-net#10103. The LED init script that was added in sonic-net#9769 enables the port LEDs, but it turns out that the linkscan change combined with Broadcom SAI 6.0 breaks detection of port status on boot. Without the linkscan and sleep, the LED still work as expected, and the port status is correct again. Signed-off-by: Lukas Stockner <lstockner@genesiscloud.com>
lukasstockner
added a commit
to genesiscloud/sonic-buildimage
that referenced
this pull request
Apr 2, 2023
Fixes sonic-net#10103. The LED init script that was added in sonic-net#9769 enables the port LEDs, but it turns out that the linkscan change combined with Broadcom SAI 6.0 breaks detection of port status on boot. Without the linkscan and sleep, the LED still work as expected, and the port status is correct again. Signed-off-by: Lukas Stockner <lstockner@genesiscloud.com>
lukasstockner
added a commit
to genesiscloud/sonic-buildimage
that referenced
this pull request
Apr 22, 2023
Fixes sonic-net#10103. The LED init script that was added in sonic-net#9769 enables the port LEDs, but it turns out that the linkscan change combined with Broadcom SAI 6.0 breaks detection of port status on boot. Without the linkscan and sleep, the LED still work as expected, and the port status is correct again. Signed-off-by: Lukas Stockner <lstockner@genesiscloud.com>
lukasstockner
added a commit
to genesiscloud/sonic-buildimage
that referenced
this pull request
Oct 31, 2023
Fixes sonic-net#10103. The LED init script that was added in sonic-net#9769 enables the port LEDs, but it turns out that the linkscan change combined with Broadcom SAI 6.0 breaks detection of port status on boot. Without the linkscan and sleep, the LED still work as expected, and the port status is correct again. Signed-off-by: Lukas Stockner <lstockner@genesiscloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
The DX030 platform has all LEDs shining green, no port status indication.
How I did it
Looking at other platforms that are Trident 3 based, we figured out that the LED configuration blobs are checked in but not loaded. We tested a few different ways of loading these blobs and the proposed one worked fine.
How to verify it
Tested on a Celestica Seastone2 DX030 switch
Testing scenarios:
Data forwarding of course still works.
Which release branch to backport (provide reason below if selected)
Reason: Having the LEDs work is considered essential for a lot of people when considering platforms.
Description for the changelog
cel/seastone2: Enable interface LEDs
A picture of a cute animal (not mandatory but encouraged)