Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix COUNTERS/Ethernet*/Pfcwd query #173

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

zbud-msft
Copy link
Contributor

@zbud-msft zbud-msft commented Dec 4, 2023

Why I did it

ADO: 26430138

Currently Pfcwd query is not working as the mapping of Pfwd to oid is broken due to incorrect table name. Fix table name and corresponding UT.

How I did it

Fix table name and corresponding UT.

How to verify it

UT

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

Copy link

@developfast developfast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zbud-msft do you know how the table name got changed or where it got changed?

@zbud-msft
Copy link
Contributor Author

@zbud-msft do you know how the table name got changed or where it got changed?

@developfast sonic-net/sonic-swss-common#266

Copy link

@developfast developfast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zbud-msft zbud-msft merged commit 88e82d4 into sonic-net:master Dec 6, 2023
5 checks passed
faraazbrcm pushed a commit to faraazbrcm/sonic-gnmi that referenced this pull request Jan 8, 2024
@zbud-msft
Copy link
Contributor Author

@StormLiangMS This PR must be merged before #178

@mssonicbld
Copy link

Cherry-pick PR to 202305: #187

@mssonicbld
Copy link

Cherry-pick PR to 202311: #211

mssonicbld pushed a commit that referenced this pull request Apr 8, 2024
zbud-msft added a commit that referenced this pull request Apr 23, 2024
yxieca added a commit that referenced this pull request Apr 29, 2024
Revert "[action] [PR:173] Replace PFC_WD_TABLE with PFC_WD (#173)"
zbud-msft added a commit that referenced this pull request Jul 29, 2024
zbud-msft added a commit to zbud-msft/sonic-gnmi that referenced this pull request Jul 29, 2024
zbud-msft added a commit to zbud-msft/sonic-gnmi that referenced this pull request Jul 29, 2024
yejianquan added a commit to yejianquan/sonic-gnmi that referenced this pull request Jul 29, 2024
bingwang-ms added a commit that referenced this pull request Jul 30, 2024
Revert "Replace PFC_WD_TABLE with PFC_WD (#173)"
qiluo-msft pushed a commit that referenced this pull request Sep 6, 2024
This reverts commit 88e82d4.

Reverts #173

Reverting as there is future work planned: 26034082

Previous reverts on other branches: 

202305: 802dbb7
202311: db6f983
202405: 9785246
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants