Return GNMI API error when ZMQ operation failed. #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ganglyu
reviewed
Jul 12, 2024
| } | ||
|
|
||
| return | ||
| return err |
There was a problem hiding this comment.
There will be different kinds of error:
Connection break:
"zmq connection break, endpoint: " + m_endpoint + ", error: " + to_string(rc)
Send message failed:
"zmq send failed, endpoint: " + m_endpoint + ", error: " + to_string(rc)
liuh-80
force-pushed
the
dev/liuh/return-err-when-zmq-failed
branch
from
652f2e5
to
df04cb0
Compare
ganglyu
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return GNMI API error when ZMQ operation failed.
Why I did it
When ZMQ is full, GNMI service crash.
How I did it
Return API error instead of panic.
How to verify it
Manually test.
Work item tracking
Microsoft ADO (number only): 28694022
Which release branch to backport (provide reason below if selected)
Description for the changelog
Return GNMI API error when ZMQ operation failed.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)