Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cli] Add the definitions of mclag and pch_id to fix the startup failure. #103

Merged
merged 1 commit into from
Apr 19, 2023
Merged

[cli] Add the definitions of mclag and pch_id to fix the startup failure. #103

merged 1 commit into from
Apr 19, 2023

Conversation

linemma
Copy link
Contributor

@linemma linemma commented Feb 16, 2023

What I did
[cli] Add the definitions of mclag and pch_id to fix the startup failure.

  1. Syncronize the definitions of mclag from PR#87.
  2. Add the definition of pch_id.

Why I did it
There are some problems when startup 'sonic-cli'.

admin@sonic:~$ sonic-cli
Error: Unresolved PTYPE "MCLAG_KA_INTERVAL_RANGE" in PARAM "KA"
admin@sonic:~$

How I verified it

admin@sonic:~$ sonic-cli
sonic#
  configure  Enter configuration mode
  exit       Exit from the CLI
  no         No commands under exec mode
  show       Show running system information
  system     System command

Signed-off-by: Emma Lin <emma_lin@edge-core.com>

@linemma
[cli] Add the definitions of mclag and pch_id to fix the startup fail…
5fabbfe 
…ure.

1. Syncronize the definitions of mclag from PR#87.
2. Add the definition of pch_id.
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 16, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: linemma / name: Emma Lin (5fabbfe)

@sachinholla sachinholla mentioned this pull request Apr 17, 2023
Merged
@adyeung
Copy link

adyeung commented Apr 18, 2023

@tomek-US pls help review and merge

tomek-US
tomek-US approved these changes Apr 19, 2023
View reviewed changes
Copy link

@tomek-US tomek-US left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomek-US tomek-US merged commit 88b1ec1 into sonic-net:master Apr 19, 2023
@adyeung adyeung mentioned this pull request Apr 24, 2023
Closed
patilshashidhar added a commit to patilshashidhar/sonic-platform-vpp that referenced this pull request Apr 28, 2023
@patilshashidhar
Issue sonic-net#18 : Migrate syncd-vpp and docker-sonic-vpp container…
7261521 
… image to debian bullseye

Moved to a more recent SONiC label which has fix for sonic-cli issue
sonic-net/sonic-mgmt-framework#103

Unit tested basic interface, sub-interface , address, and route configurations.

Signed-off-by: Shashidhar Patil <shashidhar.patil@gmail.com>
@patilshashidhar patilshashidhar mentioned this pull request Apr 28, 2023
Merged
@joyas-joseph joyas-joseph mentioned this pull request May 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomek-US tomek-US tomek-US approved these changes

@sachinholla sachinholla sachinholla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@linemma @adyeung @tomek-US @sachinholla