Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need new test: DHCP Relay supports using src intf ip in relay #3624

Closed
qiluo-msft opened this issue Jun 7, 2021 · 1 comment · Fixed by #14653
Closed

Need new test: DHCP Relay supports using src intf ip in relay #3624

qiluo-msft opened this issue Jun 7, 2021 · 1 comment · Fixed by #14653
Assignees
@yejianquan @yaqiangz
Labels
P0 Test gap

Comments

@qiluo-msft
Copy link
Contributor

Description
This is to test the new feature in sonic-net/sonic-buildimage#7055
@yxieca yxieca assigned ghost Sep 9, 2021
@yxieca yxieca added the P0 label Sep 23, 2021
@kellyyeh kellyyeh assigned kellyyeh and unassigned lerry-lee Sep 1, 2022
@StormLiangMS StormLiangMS assigned yaqiangz and unassigned kellyyeh Jun 6, 2024
@yejianquan yejianquan self-assigned this Sep 16, 2024
@yejianquan
Copy link
Collaborator

Assign to @yejianquan for hackaton events

@yejianquan yejianquan mentioned this issue Sep 19, 2024
Merged
8 tasks
arista-hpandya pushed a commit to arista-hpandya/sonic-mgmt that referenced this issue Oct 2, 2024
@yejianquan @arista-hpandya
[Test gap] Test dhcp_relay with source port ip enabled (sonic-net#14653)
3112407 
Description of PR
Summary:
Fixes sonic-net#3624
Mitigate the test gap: Test dhcp relay with source port ip in relay enabled.

Approach
What is the motivation for this PR?
Fixes sonic-net#3624
Mitigate the test gap: Test dhcp relay with source port ip in relay enabled.

How did you do it?
Enhance dhcp_relay ptf test to verify the src_ip in relay packets
Add a fixture which modify deployment_id to 8 and enable source port ip in relay
Add a test case exactly same with test_dhcp_relay_default but include fixture enable_source_port_ip_in_relay.
How did you verify/test it?
Run on local dev vm,
dhcp_relay/test_dhcp_relay.py::test_interface_binding PASSED [ 12%]
dhcp_relay/test_dhcp_relay.py::test_dhcp_relay_default PASSED [ 25%]
dhcp_relay/test_dhcp_relay.py::test_dhcp_relay_with_source_port_ip_in_relay_enabled PASSED [ 37%]
dhcp_relay/test_dhcp_relay.py::test_dhcp_relay_after_link_flap PASSED [ 50%]
dhcp_relay/test_dhcp_relay.py::test_dhcp_relay_start_with_uplinks_down PASSED [ 62%]
dhcp_relay/test_dhcp_relay.py::test_dhcp_relay_unicast_mac PASSED [ 75%]
dhcp_relay/test_dhcp_relay.py::test_dhcp_relay_random_sport PASSED [ 87%]
dhcp_relay/test_dhcp_relay.py::test_dhcp_relay_counter SKIPPED (skip...) [100%]
and PR test will test it again.

co-authorized by: jianquanye@microsoft.com
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yejianquan yejianquan

@yaqiangz yaqiangz

Labels
P0 Test gap
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Test gap] Test dhcp_relay with source port ip enabled yejianquan/sonic-mgmt
6 participants
@yejianquan @qiluo-msft @yxieca @yaqiangz @lerry-lee @kellyyeh