[everflow] align capability fetch with new swss implementation #4773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stepan Blyshchak <stepanb@nvidia.com>
bingwang-ms
reviewed
Nov 29, 2021
| test_ingress_mirror_on_ingress_acl = "MIRROR_INGRESS_ACTION" in acl_capabilities["INGRESS"]["action_list"] | ||
| test_ingress_mirror_on_egress_acl = "MIRROR_INGRESS_ACTION" in acl_capabilities["EGRESS"]["action_list"] | ||
| test_egress_mirror_on_egress_acl = "MIRROR_EGRESS_ACTION" in acl_capabilities["EGRESS"]["action_list"] | ||
| test_egress_mirror_on_ingress_acl = "MIRROR_EGRESS_ACTION" in acl_capabilities["INGRESS"]["action_list"] |
There was a problem hiding this comment.
Can we make it back compatible by checking switch_capabilities if acl_capabilities is empty?
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
bingwang-ms
approved these changes
Dec 7, 2021
|
Look good to me. Let's merge it and have it verified in nightly test. Thanks |
AntonHryshchuk
pushed a commit
to AntonHryshchuk/sonic-mgmt
that referenced
this pull request
Jan 4, 2022
…-net#4773) * [everflow] align capability fetch with new swss implementation Signed-off-by: Stepan Blyshchak <stepanb@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stepan Blyshchak stepanb@nvidia.com
Description of PR
Summary: align capability fetch with new swss implementation
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
To align with new AclOrch implementation added in sonic-net/sonic-swss#1982.
How did you do it?
Implemented acl_capabilities_facts.
How did you verify/test it?
Run the everflow test suite.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation