Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test_fgnhg] Fix rebase issue and enable vxlan port configuration from top level #4780

Merged
merged 1 commit into from
Dec 7, 2021

Conversation

anish-n
Copy link
Contributor

@anish-n anish-n commented Nov 29, 2021

Description of PR

Summary:
Fixes syntax error seen after latest PR with rebase issue was merged in. It also makes a small improvement to the test such that vxlan port configuration happens from the top level test and is passed down to PTF vs being hardcoded in the ptf test.

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911

Approach

What is the motivation for this PR?

Fix issue and make a small improvement to the test case

How did you do it?

How did you verify/test it?

Tested via sonic-mgmt on DUT

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@anish-n anish-n requested a review from a team as a code owner November 29, 2021 23:12
@anish-n
Copy link
Contributor Author

anish-n commented Nov 30, 2021

/azpw run

@wangxin
Copy link
Collaborator

wangxin commented Dec 1, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@bingwang-ms
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@bingwang-ms
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@bingwang-ms bingwang-ms merged commit bd06538 into sonic-net:master Dec 7, 2021
AntonHryshchuk pushed a commit to AntonHryshchuk/sonic-mgmt that referenced this pull request Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants