[sonic-platform-base] Introduce APIs for modular chassis support #124
Conversation
There was a problem hiding this comment.
All comments are addressed.
get_change_event() - Will be implemented in an incremental PR. We will make a note of it.
get_name() - Standard name format as updated in the comments
get_description() - PID of the card that can be updated when the information is available.
Discuss additional options for reboot options - linux, cpu complex or entire card. |
mprabhu-nokia
force-pushed
the
nokia-chassisd-pmon
branch
from
5ad58e1
to
8622bc6
Compare
Introducing CardBase class to repesent pluggable cards in a voq-chassis. Add helper APIs in chassis_base.py for num_cards(), get_card_list(), get_controlcard_instance() and get_my_instance()
Addressing review-comments
Fixes for other review comments * Add more decscriptive headers for APIs
Can this be facilitated to reboot() api as part of current code/PR? |
In module_base.py, introducing a reboot_type option in reboot() API as per review comments.
|
@mprabhu-nokia: Can you please update the PR title and description since they no longer reflect the changes here? |
mprabhu-nokia
changed the title
Agree. Fixed both to reflect latest changes. |
|
@Staphylo: Can you please review this, also? |
|
LGTM |
Changing get_status() to get_oper_status() since the signature is different from the device_base.get_status() which returns a bool
|
@mprabhu-nokia: Once this PR merges, can you please also add regression tests for these new API methods in the sonic-mgmt repo: |
Yes, will do. |
|
@lguohan: Since you had outstanding comments, can you please review again before merge? |
jleveque
changed the title
sonic-platform-base: Changes to enhance module_base.py and chassis_base.py for modular chassis
HLD: sonic-net/SONiC#646
- What I did
Enhance ModuleBase with new APIs to repesent pluggable cards in a voq-chassis.
Enhance ChassisBase with new APIs
- How I did it
Add helper APIs in module_base.py
Add helper APIs in chassis_base.py
- How I verified it