add data for telemtery enhancement for 'active-active' cable type #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zjswhhh
reviewed
Jan 20, 2023
Comment on lines
+1715
to
+1720
| if query_type == "link_state": | ||
| grpc_port_stats[port]["link_state_probe_count"] = str(int(stat.get("link_state_probe_count", 0)) + 1 ) | ||
| grpc_port_stats[port]["peer_link_state_probe_count"] = str(int(stat.get("peer_link_state_probe_count", 0)) + 1 ) | ||
| elif query_type == "oper_state": | ||
| grpc_port_stats[port]["operation_state_probe_count"] = str(int(stat.get("operation_state_probe_count", 0)) + 1 ) | ||
| grpc_port_stats[port]["peer_operation_state_probe_count"] = str(int(stat.get("peer_operation_state_probe_count", 0)) + 1 ) |
There was a problem hiding this comment.
Just being curious, what are the counters used for?
There was a problem hiding this comment.
These counters are for noting how many time gRPC API's are being called from ycabled's perspective.
yxieca
pushed a commit
that referenced
this pull request
Jan 23, 2023
Signed-off-by: vaibhav-dahiya vdahiya@microsoft.com This PR adds logic to add the following gRPC relevant telemetry schema fields in the state DB table MUX_CABLE_INFO 1) "self_link_state" 2) "up" 3) "peer_link_state" 4) "up" 5) "self_oper_state" 6) "up" 7) "peer_oper_state" 8) "up" 9) "server_version" 10) "1.0" 11) "grpc_connection_status" 12) "READY" 13) "self_mux_direction" 14) "active" 15) "peer_mux_direction" 16) "active" 17) "peer_mux_direction_probe_count" 18) "23" 19) "mux_direction_probe_count" 20) "23" 21) "link_state_probe_count" 22) "1" 23) "peer_link_state_probe_count" 24) "1" 25) "operation_state_probe_count" 26) "1" 27) "peer_operation_state_probe_count" 28)"1" This data will allow telemetry to check gRPC stats and version of the server and be able to raise alert if needed appropriatley. Description gPRC data for telemetry appropriate logic is added for handling the gRPC stats and RPC's are called and counted as appropriate Motivation and Context How Has This Been Tested? UT and putting the changes on the testbed
dprital
added a commit
to dprital/sonic-buildimage
that referenced
this pull request
Jan 30, 2023
Update sonic-platform-daemons submodule pointer to include the following: * 906d198 add data for telemtery enhancement for 'active-active' cable type ([sonic-net#332](sonic-net/sonic-platform-daemons#332)) Signed-off-by: dprital <drorp@nvidia.com>
8 tasks
StormLiangMS
pushed a commit
that referenced
this pull request
Feb 4, 2023
Signed-off-by: vaibhav-dahiya vdahiya@microsoft.com This PR adds logic to add the following gRPC relevant telemetry schema fields in the state DB table MUX_CABLE_INFO 1) "self_link_state" 2) "up" 3) "peer_link_state" 4) "up" 5) "self_oper_state" 6) "up" 7) "peer_oper_state" 8) "up" 9) "server_version" 10) "1.0" 11) "grpc_connection_status" 12) "READY" 13) "self_mux_direction" 14) "active" 15) "peer_mux_direction" 16) "active" 17) "peer_mux_direction_probe_count" 18) "23" 19) "mux_direction_probe_count" 20) "23" 21) "link_state_probe_count" 22) "1" 23) "peer_link_state_probe_count" 24) "1" 25) "operation_state_probe_count" 26) "1" 27) "peer_operation_state_probe_count" 28)"1" This data will allow telemetry to check gRPC stats and version of the server and be able to raise alert if needed appropriatley. Description gPRC data for telemetry appropriate logic is added for handling the gRPC stats and RPC's are called and counted as appropriate Motivation and Context How Has This Been Tested? UT and putting the changes on the testbed
liat-grozovik
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Feb 14, 2023
Update sonic-platform-daemons submodule pointer to include the following: * 906d198 add data for telemtery enhancement for 'active-active' cable type ([#332](sonic-net/sonic-platform-daemons#332)) Signed-off-by: dprital <drorp@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: vaibhav-dahiya vdahiya@microsoft.com
This PR adds logic to add the following gRPC relevant telemetry schema fields in the state DB table
MUX_CABLE_INFOThis data will allow telemetry to check gRPC stats and version of the server and be able to raise alert if needed appropriatley.
Description
gPRC data for telemetry
appropriate logic is added for handling the gRPC stats and RPC's are called and counted as appropriate
Motivation and Context
How Has This Been Tested?
UT and putting the changes on the testbed
Additional Information (Optional)