Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Voqs to Virtual Switch #1061

Merged
merged 8 commits into from
Sep 21, 2022
Merged

Conversation

skbarista
Copy link
Contributor

Add Voqs to Virtual Switch. This is needed for virtual chassis tests to pass it sonic-net/sonic-swss#1913

@@ -108,6 +108,8 @@ namespace saivs
_In_ uint32_t sys_port_count,
_In_ const sai_system_port_config_t *sys_port_cfg_list);

sai_status_t create_voqs();
sai_status_t create_voq_per_sysport(_In_ sai_object_id_t sys_port_id);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move paremater to second line like in other functions

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed the parameter. The coverage seems to be not detecting the coverage added my new test. I checked in my local environment, the new functions are exercised by the test I added. @kcudnik

@kcudnik
Copy link
Collaborator

kcudnik commented Jun 12, 2022

please satisfy code coverage

@skbarista
Copy link
Contributor Author

@kcudnik I added test_voq_switch_create and confirmed new functions are getting exercised. Would you happen to know any reason why the coverage would not catch the new coverage added by this test? tagging @arlakshm for visibility,

@kcudnik
Copy link
Collaborator

kcudnik commented Jun 27, 2022

not sure about that, i believe i had the same issue that tests added in perl script was not counting coverage, maybe they generate gcov files in different location or something like that, and it's not picked up by code coverage engine, i don't have root cause here :(

@arlakshm
Copy link
Contributor

/Azp run Azure.sonic-sairedis

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vmittal-msft vmittal-msft merged commit af80caa into sonic-net:master Sep 21, 2022
dprital added a commit to dprital/sonic-buildimage that referenced this pull request Oct 19, 2022
Update sonic-sairedis submodule pointer to include the following:
* af80caa Add Voqs to Virtual Switch ([sonic-net#1061](sonic-net/sonic-sairedis#1061))
* f9008ad [fastboot] fastboot enhancement: Use warm-boot infrastructure for fast-boot ([sonic-net#1100](sonic-net/sonic-sairedis#1100))

Signed-off-by: dprital <drorp@nvidia.com>
pettershao-ragilenetworks pushed a commit to pettershao-ragilenetworks/sonic-sairedis that referenced this pull request Nov 18, 2022
* Add Voqs to Virtual Switch
* Add UnitTest.
@yxieca
Copy link
Contributor

yxieca commented Nov 29, 2022

@skbarista this change cannot be cherry-picked cleanly to 202205. Can you enter new PR for 202205 branch?

skbarista added a commit to skbarista/sonic-sairedis that referenced this pull request Nov 30, 2022
* Add Voqs to Virtual Switch
* Add UnitTest.
@skbarista
Copy link
Contributor Author

@yxieca I raised #1161

skbarista added a commit to skbarista/sonic-sairedis that referenced this pull request Dec 2, 2022
* Add Voqs to Virtual Switch
* Add UnitTest.
@yxieca
Copy link
Contributor

yxieca commented Dec 12, 2022

#1162 is the 202205 PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants