Support SAI_PORT_ATTR_PORT_SERDES_ID on vs gearbox #1082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kcudnik
reviewed
Jul 19, 2022
| @@ -273,6 +278,7 @@ sai_status_t SwitchBCM81724::refresh_read_only( | |||
| */ | |||
|
|
|||
| case SAI_PORT_ATTR_OPER_STATUS: | |||
| case SAI_PORT_ATTR_PORT_SERDES_ID: | |||
There was a problem hiding this comment.
SAI_PORT_ATTR_PORT_SERDES_ID is readonly attribute, and normally it should be recalculated each time is queried but if it's null, then is ok to jus return here
There was a problem hiding this comment.
@kcudnik Do I need to fix something here? Other than here, it looks like all checks have been passed.
kcudnik
approved these changes
Jul 19, 2022
|
please address errors and issues |
|
/azpw run Azure.sonic-sairedis |
|
/AzurePipelines run Azure.sonic-sairedis |
|
Azure Pipelines successfully started running 1 pipeline(s). |
7 tasks
pettershao-ragilenetworks
pushed a commit
to pettershao-ragilenetworks/sonic-sairedis
that referenced
this pull request
Nov 18, 2022
This change is to support SAI_PORT_ATTR_PORT_SERDES_ID on the SAI for vs gearbox
jimmyzhai
pushed a commit
to sonic-net/sonic-swss
that referenced
this pull request
Dec 8, 2022
What I did This change adds support for setting tx tap or tuning values on gearbox ports. It uses the SAI attributes such as SAI_PORT_SERDES_ATTR_TX_FIR_PRE1 to communicate with SAI-based gearbox drivers. For the values, they are provided in the format like "system_tx_fir_pre2": [1,1] for an interface from gearbox_config.json. Why I did it How I verified it We verified that values provided in sonic-net/sonic-buildimage#10084 are set to the chip with this change. Added test to tests/test_gearbox.py. The added test will not pass until the following two changes (which should be merged first) are merged: Support SAI_PORT_ATTR_PORT_SERDES_ID on vs gearbox: sonic-net/sonic-sairedis#1082 Add gearbox taps to vs gearbox_config.json: sonic-net/sonic-buildimage#11480
dgsudharsan
pushed a commit
to dgsudharsan/sonic-swss
that referenced
this pull request
Dec 9, 2022
What I did This change adds support for setting tx tap or tuning values on gearbox ports. It uses the SAI attributes such as SAI_PORT_SERDES_ATTR_TX_FIR_PRE1 to communicate with SAI-based gearbox drivers. For the values, they are provided in the format like "system_tx_fir_pre2": [1,1] for an interface from gearbox_config.json. Why I did it How I verified it We verified that values provided in sonic-net/sonic-buildimage#10084 are set to the chip with this change. Added test to tests/test_gearbox.py. The added test will not pass until the following two changes (which should be merged first) are merged: Support SAI_PORT_ATTR_PORT_SERDES_ID on vs gearbox: sonic-net/sonic-sairedis#1082 Add gearbox taps to vs gearbox_config.json: sonic-net/sonic-buildimage#11480 Updated handling of VRF_VNI mapping and VLAN_VNI mapping for same VNI ID fixed compile issues Updated code for the flow where VRF VNI mapping is processed first followed by VLAN VNI mapping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is to support SAI_PORT_ATTR_PORT_SERDES_ID on the SAI for vs gearbox