[syncd_init_common.sh] fix fast reboot backwards compatibility #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should handle both cases for backward-compatible with 201803: - fast-reboot - SONIC_BOOT_TYPE=fast-reboot Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>
qiluo-msft
reviewed
Jun 25, 2019
syncd/scripts/syncd_init_common.sh
Outdated
| ;; | ||
| fastfast) | ||
| case "$(cat /proc/cmdline)" in | ||
| *fastfast*) |
There was a problem hiding this comment.
fastfast [](start = 3, length = 8)
Be more specific SONIC_BOOT_TYPE=fastfast #Closed
qiluo-msft
reviewed
Jun 25, 2019
syncd/scripts/syncd_init_common.sh
Outdated
| if [ -e /var/warmboot/warm-starting ]; then | ||
| FASTFAST_REBOOT='yes' | ||
| fi | ||
| ;; | ||
| *fast*) |
There was a problem hiding this comment.
fast [](start = 3, length = 4)
This one is also too general. We can match for 2 patterns:
*SONIC_BOOT_TYPE=fast**fast-reboot*#Closed
Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>
qiluo-msft
approved these changes
Jun 26, 2019
qiluo-msft
pushed a commit
that referenced
this pull request
Jun 26, 2019
* [syncd_init_common.sh] fix fast reboot backwards compatibility We should handle both cases for backward-compatible with 201803: - fast-reboot - SONIC_BOOT_TYPE=fast-reboot * handle review comments
qiluo-msft
pushed a commit
that referenced
this pull request
Jun 26, 2019
* [syncd_init_common.sh] fix fast reboot backwards compatibility We should handle both cases for backward-compatible with 201803: - fast-reboot - SONIC_BOOT_TYPE=fast-reboot * handle review comments
pettershao-ragilenetworks
pushed a commit
to pettershao-ragilenetworks/sonic-sairedis
that referenced
this pull request
Nov 18, 2022
…-net#480) * [syncd_init_common.sh] fix fast reboot backwards compatibility We should handle both cases for backward-compatible with 201803: - fast-reboot - SONIC_BOOT_TYPE=fast-reboot * handle review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should handle both cases for backward-compatible with 201803:
Signed-off-by: Stepan Blyschak stepanb@mellanox.com