[sairedis] Fail get/clear api on objects created in init view mode #930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add also nice syslog message why api failed.
lguohan
previously approved these changes
Sep 15, 2021
|
seems like this PR is braking 28 tests, but i can't figure why since logs are not published from failed tests :/ |
|
this PR needs fix, since syncd on first init view goes directly to appl view, but OA thinks it's actually init view. probably fix for that would be to move this change to syncd side |
judyjoseph
pushed a commit
that referenced
this pull request
Oct 6, 2021
pettershao-ragilenetworks
pushed a commit
to pettershao-ragilenetworks/sonic-sairedis
that referenced
this pull request
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add also nice syslog message why api failed. This will prevent going to syncd and fail at translateVidToRid, it will now return failure on sairedis orchagent level.