[202205] Fix sonic-db-cli dictionary output format not backward compatible issue #690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ue. (sonic-net#678) #### Why I did it Fix sonic-db-cli dictionary output format not backward compatible issue: sonic-net/sonic-buildimage#11945 #### How I did it Improve redis reply format method, keep same format with redis-py. #### How to verify it Add c++ unit test to cover all code. Pass all E2E test scenario. #### Which release branch to backport (provide reason below if selected) <!-- - Note we only backport fixes to a release branch, *not* features! - Please also provide a reason for the backporting below. - e.g. - [x] 202006 --> - [ ] 201811 - [ ] 201911 - [ ] 202006 - [ ] 202012 - [ ] 202106 - [ ] 202111 #### Description for the changelog Fix sonic-db-cli dictionary output format not backward compatible issue. #### Link to config_db schema for YANG module changes <!-- Provide a link to config_db schema for the table for which YANG model is defined Link should point to correct section on https://github.com/Azure/SONiC/wiki/Configuration. --> #### A picture of a cute animal (not mandatory but encouraged)
liat-grozovik
approved these changes
Sep 19, 2022
This was referenced Sep 19, 2022
Merged
liat-grozovik
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Sep 20, 2022
) - Why I did it To pickup new commit from sonic-swss-common submodule: afd2382 [202205] Fix sonic-db-cli dictionary output format not backward compatible issue. sonic-net/sonic-swss-common#690 - How I did it Advance the sonic-swss-common submodule pointer Signed-off-by: Kebo Liu <kebol@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to backport PR fix #678 to 202205 branch.
since the original PR has not been cherry-picked yet, so create this PR directly to backport the fix.
If the original PR will be cherry-picked, then this PR should be closed.
Why I did it
Fix sonic-db-cli dictionary output format not backward compatible issue: sonic-net/sonic-buildimage#11945
How I did it
Improve redis reply format method, keep same format with redis-py.
How to verify it
Add c++ unit test to cover all code.
Pass all E2E test scenario.
Which release branch to backport (provide reason below if selected)
Description for the changelog
Fix sonic-db-cli dictionary output format not backward compatible issue.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)