Change eventd ZMQ endpoints from localhost to docker network #923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes sonic-net/sonic-buildimage#195591
Why I did it:
For single-asic devices where host and docker containers share the same namespace, using localhost IP for ZMQ sockets worked as all containers were able to create a socket and connect to XSUB endpoint in order to publish events
However, in multi-asic devices, since certain dockers will have different network namespaces, we need to expose the ZMQ endpoint such that all dockers and host can connect to it in order to publish event. We can do this by using the docker network which is exposed to all containers.
With this change, we will be using docker network IP defined in docker.service.conf.