fix parameter use

Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
sonic-net · Feb 14, 2024 · 3ab9137 · 3ab9137
1 parent c905608
commit 3ab9137
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/orchagent/dash/dashorch.cpp b/orchagent/dash/dashorch.cpp
@@ -37,7 +37,7 @@ DashOrch::DashOrch(DBConnector *db, vector<string> &tableName, ZmqServer *zmqSer
     SWSS_LOG_ENTER();
 }
 
-bool DashOrch::getRouteTypeActions(dash::route_type::RoutingType routing_type, dash::route_type::RouteType* route_type)
+bool DashOrch::getRouteTypeActions(dash::route_type::RoutingType routing_type, dash::route_type::RouteType& route_type)
 {
     SWSS_LOG_ENTER();
 
@@ -48,7 +48,7 @@ bool DashOrch::getRouteTypeActions(dash::route_type::RoutingType routing_type, d
         return false;
     }
 
-    route_type = &it->second;
+    route_type = it->second;
     return true;
 }
 

diff --git a/orchagent/dash/dashorch.h b/orchagent/dash/dashorch.h
@@ -39,7 +39,7 @@ class DashOrch : public ZmqOrch
 public:
     DashOrch(swss::DBConnector *db, std::vector<std::string> &tables, swss::ZmqServer *zmqServer);
     const EniEntry *getEni(const std::string &eni) const;
-    bool getRouteTypeActions(dash::route_type::RoutingType routing_type, dash::route_type::RouteType* route_type);
+    bool getRouteTypeActions(dash::route_type::RoutingType routing_type, dash::route_type::RouteType& route_type);
 
 private:
     ApplianceTable appliance_entries_;

diff --git a/orchagent/dash/dashvnetorch.cpp b/orchagent/dash/dashvnetorch.cpp
@@ -288,7 +288,7 @@ void DashVnetOrch::addOutboundCaToPa(const string& key, VnetMapBulkContext& ctxt
 
     DashOrch* dash_orch = gDirectory.get<DashOrch*>();
     dash::route_type::RouteType route_type_actions;
-    if (!dash_orch->getRouteTypeActions(ctxt.metadata.action_type(), &route_type_actions))
+    if (!dash_orch->getRouteTypeActions(ctxt.metadata.action_type(), route_type_actions))
     {
         SWSS_LOG_ERROR("Failed to get route type actions for %s", key.c_str());
         return;