-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sub intf] can not add sub interface to VRF #1277
Comments
1 task
neethajohn
pushed a commit
that referenced
this issue
May 24, 2021
…-default vrf (#1521) Signed-off-by: Wenda Ni <wonda.ni@gmail.com> What I did Change in IntfMgr: Use alias (instead of subIntfAlias before the change) to hold complete sub interface name; use parentAlias (instead of alias before the change) to hold parent port name. Move sub interface creation to the first place before processing fields vrf, proxy arp, and garp. In doing above, a sub interface can receive the same treatment as other types of interfaces (interface type port, type vlan) on vrf, proxy arp, and garp fields, while maintaining an indicator (parentAlias not empty) to receive treatment specific to a sub interface (creation, deletion). Why I did it Fix #1277, #1510 How I verified it vs test. Extended all test cases to test a sub interface ingress linked to a non-default vrf.
qiluo-msft
pushed a commit
that referenced
this issue
May 25, 2021
…-default vrf (#1521) Signed-off-by: Wenda Ni <wonda.ni@gmail.com> What I did Change in IntfMgr: Use alias (instead of subIntfAlias before the change) to hold complete sub interface name; use parentAlias (instead of alias before the change) to hold parent port name. Move sub interface creation to the first place before processing fields vrf, proxy arp, and garp. In doing above, a sub interface can receive the same treatment as other types of interfaces (interface type port, type vlan) on vrf, proxy arp, and garp fields, while maintaining an indicator (parentAlias not empty) to receive treatment specific to a sub interface (creation, deletion). Why I did it Fix #1277, #1510 How I verified it vs test. Extended all test cases to test a sub interface ingress linked to a non-default vrf.
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-swss
that referenced
this issue
Oct 5, 2021
…-default vrf (sonic-net#1521) Signed-off-by: Wenda Ni <wonda.ni@gmail.com> What I did Change in IntfMgr: Use alias (instead of subIntfAlias before the change) to hold complete sub interface name; use parentAlias (instead of alias before the change) to hold parent port name. Move sub interface creation to the first place before processing fields vrf, proxy arp, and garp. In doing above, a sub interface can receive the same treatment as other types of interfaces (interface type port, type vlan) on vrf, proxy arp, and garp fields, while maintaining an indicator (parentAlias not empty) to receive treatment specific to a sub interface (creation, deletion). Why I did it Fix sonic-net#1277, sonic-net#1510 How I verified it vs test. Extended all test cases to test a sub interface ingress linked to a non-default vrf.
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this issue
Feb 28, 2022
Fix the float division due to recent transfer to Python3, use floor division instead to generate integer result in the PFCWD detect/restore time calculation. Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
After config a sub interface to VRF, the result is wrong. The sub interface does not change master to the VRF but the parent interface does.
I think IntfMgr::doIntfGeneralTask may need to change.
The text was updated successfully, but these errors were encountered: