Handle the clear request for 'Q_SHARED_ALL' #1653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Petro Bratash <petrox.bratash@intel.com>
|
@akokhan @neethajohn, please review |
|
Please add unit tests. Refer tests/test_watermark.py |
neethajohn
suggested changes
Feb 25, 2021
bratashX
force-pushed
the
q_shared_all_clean
branch
from
6b9dd94
to
5e0c4af
Compare
@neethajohn Unit test was added, but test-related on sonic-net/sonic-utilities#1149, and will pass after merge this PR. |
|
@neethajohn, could you please review |
neethajohn
approved these changes
Mar 15, 2021
|
@neethajohn @lguohan could you please merge? Thanks |
neethajohn
pushed a commit
to sonic-net/sonic-utilities
that referenced
this pull request
Mar 25, 2021
Signed-off-by: Petro Bratash petrox.bratash@intel.com Depends on sonic-net/sonic-swss#1653 - What I did Add new commands : show queue persistent-watermark all show queue watermark all sonic-clear queue watermark all sonic-clear queue persistent-watermark all - How I did it Add q_shared_all type to watermarkstat file - How to verify it Execute: show queue persistent-watermark all show queue watermark all sonic-clear queue watermark all sonic-clear queue persistent-watermark all
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-swss
that referenced
this pull request
Oct 5, 2021
What I did Add handling the clear request for 'Q_SHARED_ALL' Why I did it In sonic-net/sonic-utilities#1149 added the following new commands sonic-clear queue persistent-watermark all sonic-clear queue watermark all Without these changes, commands will result in https://github.com/Azure/sonic-swss/blob/master/orchagent/watermarkorch.cpp#L221 Signed-off-by: Petro Bratash <petrox.bratash@intel.com>
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
…nic-net#1653) Fixed issue when VNET route check detects some routes as missed they are really configured. Signed-off-by: Volodymyr Samotiy <volodymyrs@nvidia.com>
malletvapid23
added a commit
to malletvapid23/Sonic-Utility
that referenced
this pull request
Aug 3, 2023
Signed-off-by: Petro Bratash petrox.bratash@intel.com Depends on sonic-net/sonic-swss#1653 - What I did Add new commands : show queue persistent-watermark all show queue watermark all sonic-clear queue watermark all sonic-clear queue persistent-watermark all - How I did it Add q_shared_all type to watermarkstat file - How to verify it Execute: show queue persistent-watermark all show queue watermark all sonic-clear queue watermark all sonic-clear queue persistent-watermark all
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Petro Bratash petrox.bratash@intel.com
What I did
Add handling the clear request for 'Q_SHARED_ALL'
Why I did it
On this PR added new commands :
Without these changes, commands will result in
https://github.com/Azure/sonic-swss/blob/master/orchagent/watermarkorch.cpp#L221
How I verified it
Run:
Details if related
PR in sonic-utilities: sonic-net/sonic-utilities#1149