Update default route status to state DB #2009

prsunny · 2021-11-05T01:33:23Z

What I did
Orchagent update of IPv4 and IPv6 default route status. If there is a valid default route, it shall be updated as state:ok. If there is no valid default route (with packet action drop), state db shall be updated as state:na

Why I did it
Default route state in state_db can be used as a signal for application to determine if there is a valid default route learned via BGP is available in orchagent

How I verified it

Details if related

redis-cli -n 6
127.0.0.1:6379[6]> KEYS *ROUTE*
1) "ROUTE_TABLE|::/0"
2) "ROUTE_TABLE|0.0.0.0/0"
127.0.0.1:6379[6]> HGETALL "ROUTE_TABLE|0.0.0.0/0"
1) "state"
2) "na"

orchagent/muxorch.cpp

orchagent/routeorch.h

prsunny · 2021-11-08T16:24:33Z

/azp run

prsunny · 2021-11-10T17:16:10Z

/azp run

azure-pipelines · 2021-11-10T17:16:21Z

Azure Pipelines successfully started running 1 pipeline(s).

prsunny · 2021-11-18T18:06:51Z

/azp run

azure-pipelines · 2021-11-18T18:07:03Z

Azure Pipelines successfully started running 1 pipeline(s).

prsunny · 2021-11-29T18:12:43Z

/azp run

azure-pipelines · 2021-11-29T18:12:54Z

Azure Pipelines successfully started running 1 pipeline(s).

qiluo-msft · 2021-12-06T21:38:23Z

This commit could not be cleanly cherry-picked to 202012. Please submit another PR.

* Orchagent update of IPv4 and IPv6 default route status. If there is a valid default route, it shall be updated as state:ok. If there is no valid default route (with packet action drop), state db shall be updated as state:na - Schema ("ROUTE_TABLE|0.0.0.0/0")

* Update default route status to state DB (#2009) * Orchagent update of IPv4 and IPv6 default route status. If there is a valid default route, it shall be updated as state:ok. If there is no valid default route (with packet action drop), state db shall be updated as state:na - Schema ("ROUTE_TABLE|0.0.0.0/0")

#### Why I did it Update sonic-swss-common 54879741 [202012][schema] Add vnet route tunnel and advertise network tables for state_db (sonic-net/sonic-swss-common#563) a5394f9d Update for BFD, default route table (sonic-net/sonic-swss-common#550) Update sonic-swss fbbe5bcc [202012][pfc_detect] fix RedisReply errors (sonic-net/sonic-swss#2078) 5762b0c2 [Reclaim buffer][202012] Reclaim unused buffer for dynamic buffer model (sonic-net/sonic-swss#1985) 33e9bd19 [Document][202012] Supply the missing ingress/egress port profile list in document (sonic-net/sonic-swss#2066) 1b6ffba1 [Reclaiming buffer][202012] Support reclaiming buffer in traditional buffer model (sonic-net/sonic-swss#2063) afb33f16 [202012] Update default route status to state DB (sonic-net/sonic-swss#2009) (sonic-net/sonic-swss#2067) b9c44f75 Common code update for reclaiming buffer (backport community PR sonic-net/sonic-swss#1996 to 202106/202012) (sonic-net/sonic-swss#2061) cf5182d8 [request parser] Allow request parser to parse multiple values

691c37b [Route bulk] Fix bugs in case a SET operation follows a DEL operation in the same bulk (sonic-net/sonic-swss#2086) a4c80c3 patch for issue sonic-net/sonic-swss#1971 - enable Rx Drop handling for cisco-8000 (sonic-net/sonic-swss#2041) 71751d1 [macsec] Support setting IPG by gearbox_config.json (sonic-net/sonic-swss#2051) 5d5c169 [bulk mode] Fix bulk conflict when in case there are both remove and set operations (sonic-net/sonic-swss#2071) 8bbdbd2 Fix SRV6 NHOP CRM object type (sonic-net/sonic-swss#2072) ef5b35f [vstest] VS test failure fix after fabric port orch PR merge (sonic-net/sonic-swss#1811) 89ea538 Supply the missing ingress/egress port profile list in document (sonic-net/sonic-swss#2064) 8123437 [pfc_detect] fix RedisReply errors (sonic-net/sonic-swss#2040) b38f527 [swss][CRM][MPLS] MPLS CRM Nexthop - switch back to using SAI OBJECT rather than SWITCH OBJECT ae061e5 create debug_shell_enable config to enable debug shell (sonic-net/sonic-swss#2060) 45e446d [cbf] Fix max FC value (sonic-net/sonic-swss#2049) b1b5b29 Initial p4orch pytest code. (sonic-net/sonic-swss#2054) d352d5a Update default route status to state DB (sonic-net/sonic-swss#2009) 24a64d6 Orchagent: Integrate P4Orch (sonic-net/sonic-swss#2029) 15a3b6c Delete the IPv6 link-local Neighbor when ipv6 link-local mode is disabled (sonic-net/sonic-swss#1897) ed783e1 [orchagent] Add trap flow counter support (sonic-net/sonic-swss#1951) e9b05a3 [vnetorch] ECMP for vnet tunnel routes with endpoint health monitor (sonic-net/sonic-swss#1955) bcb7d61 P4Orch: inital add of source (sonic-net/sonic-swss#1997) f6f6f86 [mclaglink] fix acl out ports (sonic-net/sonic-swss#2026) fd887bf [Reclaim buffer] Reclaim unused buffer for dynamic buffer model (sonic-net/sonic-swss#1910) 9258978 [orchagent, cfgmgr] Add response publisher and state recording (sonic-net/sonic-swss#1992) 3d862a7 Fixing subport vs test script for subport under VNET (sonic-net/sonic-swss#2048) fb0a5fd Don't handle buffer pool watermark during warm reboot reconciling (sonic-net/sonic-swss#1987) 16d4bcd Routed subinterface enhancements (sonic-net/sonic-swss#1907) 9639db7 [vstest/subintf] Add vs test to validate sub interface ingress to a vnet (sonic-net/sonic-swss#1642) Signed-off-by: Stephen Sun stephens@nvidia.com

Summary: Fixes # (issue) This PR is to make linkmgrd subscribe events from ROUTE_TABLE in State DB, and react accordingly: - If any of the two default route state appears to be 'na', linkmgrd should switch to standby. - If both are 'ok', there will be a mux state probing and what happens next depends on linkmgrd state machine and the probing response. Type of change: New feature Motivation for this PR: To make linkmgrd subscribe state DB route event, and handle the switchovers. Documentation: Related PR: sonic-net/sonic-swss#2009

* Orchagent update of IPv4 and IPv6 default route status. If there is a valid default route, it shall be updated as state:ok. If there is no valid default route (with packet action drop), state db shall be updated as state:na - Schema ("ROUTE_TABLE|0.0.0.0/0")

prsunny added 2 commits November 5, 2021 01:17

Default route update

894378a

Set initial state to Standby

302bcf6

prsunny requested review from lguohan and shi-su November 5, 2021 01:33

shi-su reviewed Nov 5, 2021

View reviewed changes

orchagent/muxorch.cpp Outdated Show resolved Hide resolved

orchagent/routeorch.h Outdated Show resolved Hide resolved

prsunny added 2 commits November 5, 2021 03:00

Address review comments

2babdd6

Fix line spacing

e7f2dcc

shi-su previously approved these changes Nov 5, 2021

View reviewed changes

sonic-net deleted a comment from azure-pipelines bot Nov 10, 2021

Fix typo

0377127

prsunny dismissed shi-su’s stale review via 0377127 November 29, 2021 18:32

prsunny added the Request for 202012 Branch label Nov 29, 2021

shi-su previously approved these changes Nov 29, 2021

View reviewed changes

Fix VS test

14087a1

prsunny dismissed shi-su’s stale review via 14087a1 November 29, 2021 22:49

Fix default route add to APP_DB

75cca44

shi-su approved these changes Dec 1, 2021

View reviewed changes

prsunny merged commit d352d5a into sonic-net:master Dec 1, 2021

prsunny deleted the def_route branch December 1, 2021 17:10

stephenxs mentioned this pull request Dec 1, 2021

[sonic-swss] Submodule update sonic-net/sonic-buildimage#9397

Merged

5 tasks

prsunny removed the Request for 202012 Branch label Dec 6, 2021

prsunny mentioned this pull request Dec 6, 2021

[202012] Update default route status to state DB (#2009) #2067

Merged

stephenxs mentioned this pull request Dec 14, 2021

[202012][swss-common][swss] Submodule update sonic-net/sonic-buildimage#9531

Merged

5 tasks

zjswhhh mentioned this pull request Dec 15, 2021

Linkmgrd subscribing State DB route event sonic-net/sonic-linkmgrd#13

Merged

3 tasks

stephenxs mentioned this pull request Jan 6, 2022

[sonic-swss][202111] Submodule update (#9397) sonic-net/sonic-buildimage#9685

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update default route status to state DB #2009

Update default route status to state DB #2009

prsunny commented Nov 5, 2021 •

edited

Loading

prsunny commented Nov 8, 2021

prsunny commented Nov 10, 2021

azure-pipelines bot commented Nov 10, 2021

prsunny commented Nov 18, 2021

azure-pipelines bot commented Nov 18, 2021

prsunny commented Nov 29, 2021

azure-pipelines bot commented Nov 29, 2021

qiluo-msft commented Dec 6, 2021

Update default route status to state DB #2009

Update default route status to state DB #2009

Conversation

prsunny commented Nov 5, 2021 • edited Loading

prsunny commented Nov 8, 2021

prsunny commented Nov 10, 2021

azure-pipelines bot commented Nov 10, 2021

prsunny commented Nov 18, 2021

azure-pipelines bot commented Nov 18, 2021

prsunny commented Nov 29, 2021

azure-pipelines bot commented Nov 29, 2021

qiluo-msft commented Dec 6, 2021

prsunny commented Nov 5, 2021 •

edited

Loading