[sonic-swss] : PFCWD recovery changes using DLR_INIT #2316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Plans to add test? |
The changes required for existing testcases are already addressed in the below PR. We just need to include Th3 in the platform check |
@prsunny @neethajohn I have added new test case to handle this scenario where multi port multi priority PFCWD verification will be done. I will verify Neetha changes along with that test case and push those changes in sonic-mgmt as seperate PR. |
|
@vmittal-msft , as discussed, please explore if mock tests can be added for these changes |
neethajohn
reviewed
Jul 21, 2022
prsunny
reviewed
Jul 21, 2022
vmittal-msft
force-pushed
the
vmittal/pfcwd_dlr
branch
8 times, most recently
from
4a2c3d3
to
ea29f92
Compare
neethajohn
reviewed
Jul 26, 2022
vmittal-msft
force-pushed
the
vmittal/pfcwd_dlr
branch
10 times, most recently
from
6bd3850
to
8c5d31e
Compare
vmittal-msft
force-pushed
the
vmittal/pfcwd_dlr
branch
3 times, most recently
from
9c34885
to
f4dbc73
Compare
vmittal-msft
force-pushed
the
vmittal/pfcwd_dlr
branch
from
c911697
to
dba37b7
Compare
7 tasks
prsunny
previously approved these changes
Aug 5, 2022
neethajohn
previously approved these changes
Aug 8, 2022
vmittal-msft
dismissed stale reviews from neethajohn, prsunny, and gechiang
via
e76a22a
gechiang
approved these changes
Aug 10, 2022
Merged
7 tasks
yxieca
pushed a commit
that referenced
this pull request
Sep 1, 2022
dprital
added a commit
to dprital/sonic-buildimage
that referenced
this pull request
Sep 1, 2022
Update sonic-swss submodule pointer to include the following: * [BFD]Clean up state_db BFD entries on swss restart ([sonic-net#2434](sonic-net/sonic-swss#2434)) * Fix the Fec Mode Setting of gbsyncd ([sonic-net#2430](sonic-net/sonic-swss#2430)) * [neighsyncd] Enabling ipv4 link local entries for non-dualtor ([sonic-net#2427](sonic-net/sonic-swss#2427)) * tlm_teamd: Filter portchannel subinterface events from STATE_DB LAG_TABLE ([sonic-net#2408](sonic-net/sonic-swss#2408)) * PFCWD recovery changes using DLR_INIT ([sonic-net#2316](sonic-net/sonic-swss#2316)) * Dynamic port configuration - add port buffer cfg to the port ref counter ([sonic-net#2194](sonic-net/sonic-swss#2194)) Signed-off-by: dprital <drorp@nvidia.com>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
This is changing PFCWD recovery from SONIC based to SAI/SDK DLR_INIT way.
Why I did it
Existing SONIC scheme will not work for upcoming BRCM devices starting with TH3.
How I verified it
Verified this to be working fine on HW platform where the issue was seen. Added sonic-mgmt test case to handle this scenario.