[fpm] Fix FpmLink to read all netlink messages from FPM message #2492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case of using ```dplane_fpm_nl``` zebra plugin we receive RTM_DELROUTE followed by RTM_NEWROUTE in a single FPM message when route attributes change (i.e nexthops change). Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
This reverts commit 717ac02.
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s), but failed to run 1 pipeline(s). |
lguohan
approved these changes
Oct 26, 2022
|
@StormLiangMS kindly reminder to review and merge |
8 tasks
dprital
added a commit
to dprital/sonic-buildimage
that referenced
this pull request
Dec 28, 2022
Update sonic-swss submodule pointer to include the following: * 782a2ef Align watermark flow with port configuration ([sonic-net#2525](sonic-net/sonic-swss#2525)) * dca78d8 [Fdbsyncd] Bug Fix for remote MAC move to local MAC and Fix for Static MAC advertisement in EVPN. ([sonic-net#2521](sonic-net/sonic-swss#2521)) * 28aa309 [fpm] Fix FpmLink to read all netlink messages from FPM message ([sonic-net#2492](sonic-net/sonic-swss#2492)) Signed-off-by: dprital <drorp@nvidia.com>
8 tasks
liat-grozovik
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Dec 29, 2022
Update sonic-swss submodule pointer to include the following: * 782a2ef Align watermark flow with port configuration ([#2525](sonic-net/sonic-swss#2525)) * dca78d8 [Fdbsyncd] Bug Fix for remote MAC move to local MAC and Fix for Static MAC advertisement in EVPN. ([#2521](sonic-net/sonic-swss#2521)) * 28aa309 [fpm] Fix FpmLink to read all netlink messages from FPM message ([#2492](sonic-net/sonic-swss#2492)) Signed-off-by: dprital <drorp@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of using
dplane_fpm_nlzebra plugin we receive RTM_DELROUTE followed by RTM_NEWROUTE in a single FPM message when route attributes change (i.e nexthops change). Current implementation can only read the first one and ignores the rest.What I did
I fixed FPM implementation to read multiple nl messages in a single FPM message.
Why I did it
Trying to move towards using
dplane_fpm_nl.How I verified it
UT and using
dplane_fpm_nlzebra plugin.Details if related