[202211][dualtor] Fix neighbor miss when mux is not ready #2696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What I did The issue is that MuxOrch::m_syncdNeighbors assumes all cached zero-mac neighbors have tunnel routes installed. The check before adding tunnel routes ignores the following zero-mac neighbor events. Let's ensure that, if a zero-mac neighbor is present in MuxOrch::m_syncdNeighbors, it has a tunnel route installed. So let's check the tunnel route install success before adding a neighbor to MuxOrch::m_syncdNeighbors. Why I did it To fix sonic-net#2675 If MuxOrch is not fully initialized, and there is a FAILED neighbor added to kernel, the tunnel route creation will fail. But the subsequent FAILED neighbor events cannot trigger tunnel route creation because MuxOrch::m_syncdNeighbors caches the first event and regard the tunnel as already installed. How I verified it UT and verify on testbed. Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
lolyu
force-pushed
the
202211_zero_mac_fix
branch
from
0a03990
to
24369f2
Compare
|
/azp run Azure.sonic-swss |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yxieca
approved these changes
Mar 8, 2023
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
lolyu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
cherry-pick #2676 into 202211 branch
Why I did it
To fix #2675
How I verified it
UT and verify on testbed.
What I did
Why I did it
How I verified it
Details if related