Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[orchagent] Change log level from ERR to WARN for pfc asym not supported #3125

Merged
merged 2 commits into from
Apr 30, 2024
Merged

[orchagent] Change log level from ERR to WARN for pfc asym not supported #3125

merged 2 commits into from
Apr 30, 2024

Conversation

zhixzhu
Copy link
Contributor

@zhixzhu zhixzhu commented Apr 25, 2024 •
edited
Loading

What I did
Change log level from ERR to WARN for pfc asym not supported

Why I did it
To address issue reported in https://migsonic.atlassian.net/browse/MIGSMSFT-473

How I verified it
Load new debian on testbed and check the log.

cisco@r2-lc0:~$ sudo cat /var/log/syslog | grep "queryPortAttrCapabilities"
Apr 25 22:52:26.787428 r2-lc0 WARNING swss1#orchagent: :- queryPortAttrCapabilities: Failed to get attribute(SAI_PORT_ATTR_PRIORITY_FLOW_CONTROL_TX) capabilities
Apr 25 22:52:26.787846 r2-lc0 WARNING swss1#orchagent: :- queryPortAttrCapabilities: Failed to get attribute(SAI_PORT_ATTR_PRIORITY_FLOW_CONTROL_RX) capabilities
cisco@r2-lc0:~$

Details if related

@zhixzhu
change log level from ERR to WARN for pfc asym sai attribute not supp…
700bb25 
…orted

Signed-off-by: Zhixin Zhu <zhixzhu@cisco.com>
@zhixzhu zhixzhu requested a review from prsunny as a code owner April 25, 2024 17:59
@prsunny prsunny merged commit 67e0312 into sonic-net:master Apr 30, 2024
16 of 17 checks passed
@prsunny
Copy link
Collaborator

prsunny commented Apr 30, 2024

Bypassing coverage as this is a log level change

@zhixzhu zhixzhu deleted the ignore_pfc_asym_failure branch April 30, 2024 16:45
@zhixzhu
Copy link
Contributor Author

zhixzhu commented May 7, 2024 •
edited
Loading

@prsunny Could you help add label “Request for 202311 Branch“ and “Request for 202305 Branch“ to this PR?
The error msg caused several test cases failed.

I don't have privilege to add labels.

@abdosi
Copy link
Contributor

abdosi commented May 31, 2024

@StormLiangMS : Can you please help cherry-pick of this.

@StormLiangMS
Copy link
Contributor

@yxieca for 202311 cherry pick.

mssonicbld pushed a commit to mssonicbld/sonic-swss that referenced this pull request Jun 2, 2024
@zhixzhu @mssonicbld
change log level from ERR to WARN for pfc asym sai attribute not supp…
1b08631 
…orted (sonic-net#3125)

* Change log level from ERR to WARN for pfc asym not supported
@mssonicbld mssonicbld mentioned this pull request Jun 2, 2024
Merged
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202305: #3181

mssonicbld pushed a commit that referenced this pull request Jun 2, 2024
@zhixzhu @mssonicbld
change log level from ERR to WARN for pfc asym sai attribute not supp…
172da1f 
…orted (#3125)

* Change log level from ERR to WARN for pfc asym not supported
mssonicbld pushed a commit to mssonicbld/sonic-swss that referenced this pull request Jun 3, 2024
@zhixzhu @mssonicbld
change log level from ERR to WARN for pfc asym sai attribute not supp…
fde4db6 
…orted (sonic-net#3125)

* Change log level from ERR to WARN for pfc asym not supported
@mssonicbld mssonicbld mentioned this pull request Jun 3, 2024
Merged
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202311: #3182

mssonicbld pushed a commit that referenced this pull request Jun 3, 2024
@zhixzhu @mssonicbld
change log level from ERR to WARN for pfc asym sai attribute not supp…
e61e95f 
…orted (#3125)

* Change log level from ERR to WARN for pfc asym not supported
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prsunny prsunny prsunny approved these changes

Assignees
No one assigned
Labels
Approved for 202305 Branch Approved for 202311 Branch Included in 202305 Branch Included in 202311 Branch Request for 202305 Branch Request for 202311 Branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@zhixzhu @prsunny @abdosi @StormLiangMS @mssonicbld @yxieca