Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PFC-WD class cleanup #3290

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

rbpittman
Copy link

What I did

  • Merge the duplicate PfcWdDlrHandler and PfcWdSaiDlrInitHandler handlers.
  • Cisco will no longer use the zero buffer profile handler inheritance chain as a result, primarily using the dlr attribute instead.
  • The getHwCounters is promoted to the base class so the inheritance chain can be simpler and edge cases can be removed in the lossy handling.

Why I did it
To remove the unneeded zero buffer pool/profile application on cisco devices.

How I verified it
Informally verified counters are working and watchdog works on Cisco-8122 so far.
TODO: Performing more verification via tests on other asics.
TODO for msft: Broadcom validation when its dlr mode is enabled?

Details if related

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant