Adding vrrporch module #3315
Open
Adding vrrporch module #3315
+333
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The committers listed above are authorized under a signed CLA. |
|
@philo-micas @madhupalu please help review |
|
Adam,
Sure, my team is already on it
…On Thu, Oct 3, 2024 at 3:12 PM Adam Yeung ***@***.***> wrote:
@philo-micas <https://github.com/philo-micas> @madhupalu
<https://github.com/madhupalu> please help review
—
Reply to this email directly, view it on GitHub
<#3315 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALEIQNC2V7WRADAVYOV3NNDZZW6NRAVCNFSM6AAAAABPKHBD5WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJSGQZDSMRVGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
<https://aviznetworks.com/>
Madhu Paluru
Director, Engineering.
+1 408-455-5653
***@***.***
aviznetworks.com
[image: linkedin.png]
<https://www.linkedin.com/company/aviz-networks/> [image:
twitter.png] <https://twitter.com/aviznetworks> [image: youtube.png]
<https://www.youtube.com/channel/UCS0o0Lwv5M893eGpfAdOBNA>
|
nmoray
reviewed
Oct 4, 2024
|
|
||
| bool operator== (const vrrp_key_t& rhs) const | ||
| { | ||
| if (!(ip_addr == rhs.ip_addr) || port_name != rhs.port_name) |
There was a problem hiding this comment.
Shouldn't "!(ip_addr == rhs.ip_addr)" be "(ip_addr != rhs.ip_addr)" similar to other case?
nmoray
reviewed
Oct 4, 2024
| @@ -186,6 +186,8 @@ bool OrchDaemon::init() | |||
| gDirectory.set(vnet_rt_orch); | |||
| VRFOrch *vrf_orch = new VRFOrch(m_applDb, APP_VRF_TABLE_NAME, m_stateDb, STATE_VRF_OBJECT_TABLE_NAME); | |||
| gDirectory.set(vrf_orch); | |||
| VrrpOrch *vrrp_orch = new VrrpOrch(m_applDb, APP_VRRP_TABLE_NAME); | |||
There was a problem hiding this comment.
APP_VRRP_TABLE_NAME name is not defined. It needs to be defined in common/schema.h.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Adding vrrporch module
Why I did it
To listen to APPL_DB and program VRRP entities in SAI
How I verified it
UT
Details if related