Increase the watermark polling interval to 10s #777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wenda <wenni@microsoft.com>
prsunny
approved these changes
Jan 31, 2019
|
Suggest to provide more details in description especially here for "why I did this" since you now change from 1 sec to 10 sec and what issues were observed with 1sec. This would be good for any future reference |
|
I think you need to fix the watermark test (timing) since you changed the timer. |
Signed-off-by: Wenda <wenni@microsoft.com>
Signed-off-by: Wenda <wenni@microsoft.com>
|
retest this please |
|
Made to 201811 branch on 2/4/2019 |
yxieca
pushed a commit
that referenced
this pull request
Feb 5, 2019
* Increase the watermark polling interval to 10s Signed-off-by: Wenda <wenni@microsoft.com> * Update watermark test timing with 10s polling interval Signed-off-by: Wenda <wenni@microsoft.com>
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
Add a "show platform fanstatus" command to allow user fetch FAN status data. Add a "show platform temperature" command to allow user fetch thermal status data.
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-swss
that referenced
this pull request
Mar 1, 2023
…ic-net#777) This commit fixes a syncd crash seen when running the sonic-mgmt comunity test suites against the Marvell armhf platform. Analysis of the generated core file points to improper format specifiers used when writing SWSS log entries. This commit fixes that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Wenda wenni@microsoft.com
What I did
Why I did it
Observe high CPU utilization when watermark polling is enabled with 1s polling interval. Lower the polling resolution to 10s. May reduce the interval later if there will be efforts to improve the watermark read and clear path.
How I verified it
Details if related