Incorrect ACL stage CRM increment with Mirror #800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleveque
approved these changes
Feb 23, 2019
yxieca
approved these changes
Feb 23, 2019
yxieca
pushed a commit
that referenced
this pull request
Feb 23, 2019
yxieca
pushed a commit
that referenced
this pull request
Feb 23, 2019
|
Change made to 201811 branch on 2/22/2019 |
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
…ot user (sonic-net#872) Removed user privileges checks. These changes fix sonic-net#800. The ZTP PR sonic-net/sonic-ztp#13 is also required for these changes to work as expected. ``` admin@sonic:~$ show ztp status ZTP Admin Mode : True ZTP Service : Processing ZTP Status : IN-PROGRESS ZTP Source : local-fs (/host/ztp/ztp_data_local.json) Runtime : 06m 26s Timestamp : 2020-04-08 13:08:22 UTC ZTP Service is active 01-test-plugin: IN-PROGRESS ``` Signed-off-by: Rajendra Dendukuri <rajendra.dendukuri@broadcom.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
CRM counter got incremented for stage
egresswhen there is a mirror session. With the mirror session removed, the CRM counter was decremented for stageingress.Why I did it
Orchagent could crash if the used and available counters add up to
zero(divide/zero) error.How I verified it
Tested with the fix and checked for values
Details if related