This repository has been archived by the owner on Aug 31, 2022. It is now read-only.
Fix gnmi dep with Makefile workaround #65
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pra-moh
reviewed
Dec 16, 2020
| @@ -32,6 +32,7 @@ go.mod: | |||
| $(GO_DEPS): go.mod $(PATCHES) | |||
| # FIXME temporary workaround for crypto not downloading.. | |||
| $(GO) get golang.org/x/crypto/ssh/terminal@e9b2fee46413 | |||
| $(GO) get github.com/openconfig/gnmi@v0.0.0-20200617225440-d2b4e6a45802 | |||
There was a problem hiding this comment.
Fix has been already submitted #64
There was a problem hiding this comment.
Thanks @pra-moh . I will close. I still need to understand why the go.mod file changes at all. It is supposed to be like a lock file I though, but somehow in the build process it changes.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing build issue related to openconfig/gnmi library version. For some reason go.mod keeps changing, even though it is expected to be locked. Hard coding the version in the Makefile seems to fix the issue.