Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

override_config should fail immediately if the file does not exist #3164

Closed
qiluo-msft opened this issue Feb 13, 2024 · 0 comments · Fixed by #3169
Closed

override_config should fail immediately if the file does not exist #3164

qiluo-msft opened this issue Feb 13, 2024 · 0 comments · Fixed by #3169
Assignees
@wen587

Comments

@qiluo-msft
Copy link
Contributor

qiluo-msft commented Feb 13, 2024 •
edited
Loading 

          >Cannot [](http://example.com/codeflow?start=25&length=6)

This is critical failure. We need to check the condition before any real actions taken, for example stopping service.

Originally posted by @qiluo-msft in #2396 (comment)
@qiluo-msft qiluo-msft changed the title >Cannot [](http://example.com/codeflow?start=25&length=6) override_config should fail immediately if the file does not exist Feb 13, 2024
@wen587 wen587 mentioned this issue Feb 18, 2024
Merged
qiluo-msft pushed a commit that referenced this issue Feb 22, 2024
@wen587
[config] Check golden config exist early if flag is set (#3169)
6e4130d 
### What I did
Fix  #3164
Check Golden Config earlier before service is down.
#### How I did it
Move the check at the begining
#### How to verify it
Unit test
wen587 added a commit to wen587/sonic-utilities that referenced this issue Aug 27, 2024
@wen587
[config] Check golden config exist early if flag is set (sonic-net#3169)
f657d5f 
### What I did
Fix  sonic-net#3164
Check Golden Config earlier before service is down.
#### How I did it
Move the check at the begining
#### How to verify it
Unit test
mssonicbld pushed a commit to mssonicbld/sonic-utilities that referenced this issue Aug 28, 2024
@wen587 @mssonicbld
[config] Check golden config exist early if flag is set (sonic-net#3169)
46b312d 
### What I did
Fix  sonic-net#3164
Check Golden Config earlier before service is down.
#### How I did it
Move the check at the begining
#### How to verify it
Unit test
@mssonicbld mssonicbld mentioned this issue Aug 28, 2024
Merged
yxieca pushed a commit that referenced this issue Aug 28, 2024
@mssonicbld @wen587
[config] Check golden config exist early if flag is set (#3169) (#3504)
f72699f 
### What I did
Fix  #3164
Check Golden Config earlier before service is down.
#### How I did it
Move the check at the begining
#### How to verify it
Unit test

Co-authored-by: jingwenxie <jingwenxie@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wen587 wen587

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[config] Check golden config exist early if flag is set wen587/sonic-utilities
2 participants
@wen587 @qiluo-msft