-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GCU] Apply-patch fails in multi-ASIC platform due to missing YANG files changes #3443
Comments
@xincunli-sonic could you check this one too |
@jfeng-arista @kenneth-arista Could you check this issue. I feel the yang model need an update for the new attributes added via (#3255) |
@xincunli-sonic : Again should be fixed by now . Please recheck |
Referencing sonic-net/sonic-buildimage#19767 |
I can confirm that the issue is no longer present in the master branch after the fix in PR #19767. This issue can now be closed. |
Description
GCU apply-patch basic scenarios fail for multi-asic platform.
For the purpose of testing there were used same scenarios as in #3249
(empty, sunny, rainy)
It seems there are missing changes from different YANG files. In below reported issues, you will find also some suggested solutions that verified and worked.
# Problem 1
# Suggested solution 1:
In yang-models/sonic-fabric-monitor.yang, add leaf monCapacityThreshWarn and monState
# Problem 2 (after applying suggested solution 1)
# Suggested solution 2
In yang-models/sonic-fabric-port.yang, add leaf forceUnisolateStatus.
# Problem 3 (after applying suggested solution 2)
# Suggested solution 3
In yang-models/sonic-port.yang, remove the leaf lanes’s item “mandatory true”.
Note!
Please note that after this third suggested solution all basic scenarios work (sunny, rainy, empty).
However, especially for suggested solution number 3 I am quite sure that the removal of mandatory true for lanes breaks existing test "generic_config_updater/test_eth_interface.py::test_remove_lanes" which means that either it is not the optimal solution or this case needs special handling/extra fixes on top of the suggested.
Steps to reproduce the issue
For all the tests empty patch was applied.
(Reported problems output is same for non-empty patches as well.)
Describe the results you received
Failed patch-apply.
Describe the results you expected
Successful empty patch apply in all cases.
Additional information you deem important (e.g. issue happens only occasionally)
Output of
show version
The text was updated successfully, but these errors were encountered: