Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YANG model for enabling fabric monitor attribute #19767

Merged
merged 8 commits into from
Sep 9, 2024
Merged

YANG model for enabling fabric monitor attribute #19767

merged 8 commits into from
Sep 9, 2024

Conversation

jfeng-arista
Copy link
Contributor

Why I did it

The new added attributes related fabric link monitoring are missing YANG model. Adding them in this change.

For fabric monitor table:

monCapacityThreshWarn
monState

For fabric port:

forceUnisolateStatus

Work item tracking
  • Microsoft ADO (number only):

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@jfeng-arista
Copy link
Contributor Author

This is fixing #19660

@kenneth-arista @arlakshm @vmittal-msft

arlakshm
arlakshm reviewed Aug 12, 2024
View reviewed changes
Copy link
Contributor

@arlakshm arlakshm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add some UT

src/sonic-yang-models/yang-models/sonic-fabric-monitor.yang Outdated Show resolved Hide resolved
src/sonic-yang-models/yang-models/sonic-fabric-monitor.yang Outdated Show resolved Hide resolved
src/sonic-yang-models/yang-models/sonic-fabric-port.yang Show resolved Hide resolved
@arlakshm arlakshm added Chassis 🤖 Modular chassis support YANG YANG model related changes Request for 202405 Branch labels Aug 12, 2024
@jfeng-arista
Copy link
Contributor Author

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jfeng-arista
Copy link
Contributor Author

ASSERT TRUE FAILED(5085): sizeof(sai_switch_health_data_t) == (SAI_SWITCH_HEALTH_DATA_T_SIZE): wrong size of sai_switch_health_data_t, expected 16, got 4
make[2]: *** [Makefile:89: all] Error 1
make[2]: Leaving directory '/sonic/src/dash-sai/DASH/dash-pipeline/SAI/SAI/meta'

does not seem related to our code

@jfeng-arista
Copy link
Contributor Author

I see the same error on other PRs as well, thinking this is not related the change, try one more time of runming the pipleline, otherwise, we will wait for the issue get fixed upstream

@jfeng-arista
Copy link
Contributor Author

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jfeng-arista
Copy link
Contributor Author

same failure before, I will wait a bit for the upstream fix then kick off the test pipeline again

@jfeng-arista
Copy link
Contributor Author

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jfeng-arista
Copy link
Contributor Author

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kenneth-arista
Copy link
Contributor

@arlakshm @wenyiz2021 can you help unblock the ms_checker failure? We don't have permission to see what is failing.

@vmittal-msft vmittal-msft self-requested a review August 19, 2024 21:16
@vmittal-msft
Copy link
Contributor

/azp run

@azure-pipelines Azure Pipelines
Copy link

Commenter does not have sufficient privileges for PR 19767 in repo sonic-net/sonic-buildimage

ganglyu
ganglyu approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@ganglyu ganglyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jfeng-arista
Copy link
Contributor Author

LGTM

thanks

@kenneth-arista kenneth-arista mentioned this pull request Sep 5, 2024
Closed
@kenneth-arista
Copy link
Contributor

Referencing sonic-net/sonic-utilities#3443

@jfeng-arista
Copy link
Contributor Author

"Error type: DUTHOST_UNREACHABLE
Error message: DUT host unreachable for vms-kvm-dual-t0 on running test_pretest.py|||vms-kvm-dual-t0_215703
"

it failed with above issue.

kick off another build

@jfeng-arista
Copy link
Contributor Author

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jfeng-arista
Copy link
Contributor Author

Error type: START_WORKER_AGENT_FAILED
Error message: Prepare testbed failed: testbed_q_sonic-elastictest-prod-vmss-D8s-v3_216742 for START_WORKER_AGENT_FAILED, testbed_id is: 66da046a066cc8cdf5ad59eb, cmd is: Start sonic-mgmt worker agent
Operation failed with exception: Exception('Test plan id: 66da01891b0209cf5f97a1fb, status: None, result: FAILED, Elapsed 0 seconds. Check https://elastictest.org/scheduler/testplan/66da01891b0209cf5f97a1fb for test plan status')

The failure does not look related to the change

@jfeng-arista
Copy link
Contributor Author

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@qiluo-msft qiluo-msft merged commit 9989a27 into sonic-net:master Sep 9, 2024
22 checks passed
vvolam pushed a commit to vvolam/sonic-buildimage that referenced this pull request Sep 12, 2024
@jfeng-arista @vvolam
YANG model for enabling fabric monitor attribute (sonic-net#19767)
aec3a18 
### Why I did it
The new added attributes related fabric link monitoring are missing YANG model. Adding them in this change. 

For fabric monitor table: 
> monCapacityThreshWarn
> monState

For fabric port:
> forceUnisolateStatus
mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Sep 13, 2024
@jfeng-arista @mssonicbld
YANG model for enabling fabric monitor attribute (sonic-net#19767)
3c9fb94 
### Why I did it
The new added attributes related fabric link monitoring are missing YANG model. Adding them in this change. 

For fabric monitor table: 
> monCapacityThreshWarn
> monState

For fabric port:
> forceUnisolateStatus
@mssonicbld mssonicbld mentioned this pull request Sep 13, 2024
Merged
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202405: #20262

mssonicbld pushed a commit that referenced this pull request Sep 20, 2024
@jfeng-arista @mssonicbld
YANG model for enabling fabric monitor attribute (#19767)
1f070d2 
### Why I did it
The new added attributes related fabric link monitoring are missing YANG model. Adding them in this change. 

For fabric monitor table: 
> monCapacityThreshWarn
> monState

For fabric port:
> forceUnisolateStatus
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wen587 wen587 wen587 approved these changes

@qiluo-msft qiluo-msft qiluo-msft approved these changes

@vmittal-msft vmittal-msft vmittal-msft approved these changes

@ganglyu ganglyu ganglyu approved these changes

@arlakshm arlakshm arlakshm left review comments

@xincunli-sonic xincunli-sonic Awaiting requested review from xincunli-sonic

Assignees

@jfeng-arista jfeng-arista

Labels
Approved for 202405 Branch Chassis 🤖 Modular chassis support Included in 202405 Branch Request for 202405 Branch YANG YANG model related changes
Projects
SONiC Chassis
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.