Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[config][tacacs+] Change tacacs+ minimum timeout value base on specification. #1631

Merged
merged 1 commit into from
Jun 4, 2021
Merged

Conversation

steven-guo-ec
Copy link

@steven-guo-ec steven-guo-ec commented May 24, 2021

[config][tacacs+] Change tacacs+ minimum timeout value base on specification.

  • What I did
    Change the minimum timeout value of TACACS+ to follow the value in specification.

  • Why I did it
    The minimum timeout value of tacacs CLI is not the same as
    specification, so modify the CLI to make it follow it.

  • How I verified it
    Verified the minimum value is 1 on switch.

Signed-off-by: Po-hong Guo steven_guo@edge-core.com

... ification.

- What I did
    Change the minimum timeout value of TACACS+ to follow the value in
    specification.

- Why I did it
    The minimum timeout value of tacacs CLI is not the same as
    specification,so modify the CLI to make it follow it.

- How I verified it

Signed-off-by: Po-hong Guo <steven_guo@edge-core.com>
@steven-guo-ec steven-guo-ec changed the title [config]][tacacs+] Change tacacs+ minimum timeout value base on specification. [config][tacacs+] Change tacacs+ minimum timeout value base on specification. May 24, 2021
@renukamanavalan
Copy link
Contributor

Curious!
"minimum timeout value base on specification." -- Which specification is being referred here ?

@steven-guo-ec
Copy link
Author

Refer to config tacacs add section, parameter timout in Command Reference.

@renukamanavalan renukamanavalan merged commit 5a7c06a into sonic-net:202012 Jun 4, 2021
@steven-guo-ec steven-guo-ec deleted the 202012 branch June 4, 2021 03:11
qiluo-msft pushed a commit to sonic-net/sonic-buildimage that referenced this pull request Jun 11, 2021
Advance submodule head for sonic-utilities

b894c5b5 Fix build test failure caused by error module name (sonic-net/sonic-utilities#1662)
5a7c06a0 [config]][tacacs+] Change tacacs+ minimum timeout value base on spec (sonic-net/sonic-utilities#1631)
080a689c [202012] [db_migrator] fix old 1911 feature config migration to a new one. (sonic-net/sonic-utilities#1636)
43fff88c Change to use rvtysh when calling the show commands (sonic-net/sonic-utilities#1646)
88a823f0 [db_migrator][Mellanox] Update Mellanox buffer migrator with 2km-cable supported (sonic-net/sonic-utilities#1564)
d096ff78 [config]Static routes to config_db (1534)
a68d8d09 route_check: Updates  (sonic-net/sonic-utilities#1645)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants