Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sfpshow][recycle_port] Command show interfaces transceiver presence/eeprom should not display recycle port. #2109

Merged
merged 1 commit into from
Mar 22, 2022

Conversation

mlok-nokia
Copy link
Contributor

@mlok-nokia mlok-nokia commented Mar 21, 2022

What I did

Command show interfaces transceiver presence/eeprom should not display recycle port.
Script sfpshow needs to skip the recycle ports since recylce port is internal port without any SFP module.

This change is applicable to the 202111 branch

How I did it

Modify the sfpshow script with using a function recirc_prefix() to check if a port is a recycle port, skip it.

How to verify it

  1. login to the linecard which contains recycle port
  2. execute the CLI command: show interface transceiver eeprom
admin@ixre-egl-board3:~$ show interfaces transceiver presence 
Port           Presence
-------------  -----------
Ethernet0      Not present
Ethernet1      Not present
Ethernet2      Not present
Ethernet3      Not present
...
Ethernet30     Not present
Ethernet31     Not present
Ethernet32     Not present
Ethernet33     Not present
Ethernet34     Not present
Ethernet35     Not present
  1. Verify the output. It should not contain any recycle port.

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

@mlok-nokia
Copy link
Contributor Author

@prgeor @judyjoseph Hi, This PR is to address the issue of CLI command - show interfaces transceiver eeprom/presence. Please help review it. It is also applicable to branch 202111. Thanks

@prgeor prgeor merged commit 61b1396 into sonic-net:master Mar 22, 2022
judyjoseph pushed a commit that referenced this pull request Mar 28, 2022
stepanblyschak pushed a commit to stepanblyschak/sonic-utilities that referenced this pull request Apr 18, 2022
includes:

320591a [DualToR] Handle race condition between tunnel_decap and mux orchestrator (sonic-net#2114)
5027a8f Handling Invalid CRM configuration gracefully (sonic-net#2109)
0b120fa [ci]: use native arm64 and armhf pool (sonic-net#2013)
394e88a Don't handle buffer pool watermark during warm reboot reconciling (sonic-net#1987)
9008a01 patch for issue sonic-net#1971 - enable Rx Drop handling for cisco-8000 (sonic-net#2041)
2723ee3 create debug_shell_enable config to enable debug shell (sonic-net#2060)
d7be0b9 [request parser] Add unit tests for request parser for multiple values (sonic-net#1766)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants