Handle non-front-panel ports in is_rj45_port #2327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle the cases that a port is not a front-panel port in is_rj45_port Add mock test to cover the logic Signed-off-by: Stephen Sun <stephens@nvidia.com>
|
@abdosi , @judyjoseph please add this to 202205. Thanks |
Signed-off-by: Stephen Sun <stephens@nvidia.com>
judyjoseph
approved these changes
Aug 24, 2022
judyjoseph
reviewed
Aug 25, 2022
| @@ -133,7 +133,7 @@ def is_rj45_port(port_name): | |||
|
|
|||
There was a problem hiding this comment.
Did a bit of debugging and see that the below code section
if not platform_porttab_mapping_read:
platform_sfputil_read_porttab_mappings()
is actually creating this logs which @mlok-nokia was pointing out
Aug 25 05:50:23.693785 str2--lc1-1 ERR Chassis: :- initializeGlobalConfig: SonicDBConfig Global config is already initialized
There was a problem hiding this comment.
thanks. I'll check it.
There was a problem hiding this comment.
@judyjoseph if possible, can you share more details, like call stack? I don't have a multi-chassis testbed, it will be time-consuming for me to find it out. thank you.
yxieca
pushed a commit
that referenced
this pull request
Aug 26, 2022
* Handle non-front-panel ports in is_rj45_port Handle the cases that a port is not a front-panel port in is_rj45_port Add mock test to cover the logic Signed-off-by: Stephen Sun <stephens@nvidia.com> * Use APIs in sonic_platform_base Signed-off-by: Stephen Sun <stephens@nvidia.com> Signed-off-by: Stephen Sun <stephens@nvidia.com>
7 tasks
preetham-singh
pushed a commit
to preetham-singh/sonic-utilities
that referenced
this pull request
Nov 21, 2022
* Handle non-front-panel ports in is_rj45_port Handle the cases that a port is not a front-panel port in is_rj45_port Add mock test to cover the logic Signed-off-by: Stephen Sun <stephens@nvidia.com> * Use APIs in sonic_platform_base Signed-off-by: Stephen Sun <stephens@nvidia.com> Signed-off-by: Stephen Sun <stephens@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle the cases that a port is not a front-panel port in is_rj45_port
Add mock test to cover the logic
Signed-off-by: Stephen Sun stephens@nvidia.com
What I did
How I did it
How to verify it
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)