Update the DBmigrator to support persistent loglevel during warm-upgrade #2370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Could you refine the PR title? |
yxieca
previously approved these changes
Sep 28, 2022
EdenGri
changed the title
|
Done, thanks @qiluo-msft |
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
qiluo-msft
previously approved these changes
Oct 6, 2022
stephenxs
reviewed
Oct 12, 2022
tests/db_migrator_input/config_db/reclaiming-buffer-warmreboot-expected.json
Outdated
Show resolved
Hide resolved
…it's content to CONFIG DB
EdenGri
force-pushed
the
persistent_loglevel
branch
from
803167a
to
1563769
Compare
EdenGri
requested review from
yxieca and
qiluo-msft
and removed request for
yxieca and
qiluo-msft
stephenxs
approved these changes
Oct 14, 2022
qiluo-msft
approved these changes
Oct 19, 2022
yxieca
approved these changes
Oct 24, 2022
|
bandit checker is not 'Required', so please go ahead and merge it. |
vaibhavhd
reviewed
Oct 24, 2022
| @@ -2043,6 +2043,6 @@ | |||
| "admin_status": "up" | |||
| }, | |||
| "VERSIONS|DATABASE": { | |||
| "VERSION": "version_3_0_5" | |||
| "VERSION": "version_3_0_3" | |||
There was a problem hiding this comment.
Why is this change needed? Is this relevant to persistance loglevel design?
There was a problem hiding this comment.
Yes, relevant to persistance loglevel design.
There was a problem hiding this comment.
I see. I am unable to understand, can you explain why tests for reclaiming-buffer need to be changed for persistence log-level design?
There was a problem hiding this comment.
Hi @vaibhavhd
This is to change it back, correcting an error caused by an old PR. Refer this comment for details
vaibhavhd
approved these changes
Oct 24, 2022
Merged
7 tasks
dprital
added a commit
to dprital/sonic-buildimage
that referenced
this pull request
Oct 28, 2022
Update sonic-utilities submodule pointer to include the following: * 4a3d49d Fix exception in adding mirror_session when gre_type is absent ([sonic-net#2458](sonic-net/sonic-utilities#2458)) * 7e7d05c Update the DBmigrator to support persistent loglevel during warm-upgrade ([sonic-net#2370](sonic-net/sonic-utilities#2370)) * c2841b8 [doc]: Update Command-Reference.md ([sonic-net#2444](sonic-net/sonic-utilities#2444)) * 254cafc Event Counters CLI ([sonic-net#2449](sonic-net/sonic-utilities#2449)) * 2dab0d0 [techsupport] Adding FRR EVPN dumps ([sonic-net#2442](sonic-net/sonic-utilities#2442)) * 3c0aece [show][muxcable] add support for show mux firmware version all ([sonic-net#2441](sonic-net/sonic-utilities#2441)) Signed-off-by: dprital <drorp@nvidia.com>
7 tasks
preetham-singh
pushed a commit
to preetham-singh/sonic-utilities
that referenced
this pull request
Nov 21, 2022
…ade (sonic-net#2370) - What I did Add the ability to the user to save the loglevel and make it persistent to reboot with the support in warm-upgrade. (Not need to add special support for cold/fast reboot since the LOGLEVEL DB flushes during fast/cold reboot). - How I did it Add a new version to the db_migrator that will move the logger tables from the LOGLEVEL DB to the CONFIG DB - How to verify it 1. start with a switch that has an old master image (old master means that the VERSION in the config db is 3_0_5 or lower) 2. install this image to the switch 3. run warm-reboot 4. verify that the LOGLEVEL DB does not contain logger tables -> run redis-cli -n 3 keys "*" (expect to see only the JINJA2CACHE) 5. verify that the logger tables are in the config db -> run redis-cli -n 4 keys "LOGGER|*"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR needs to be merged only after the following PR: sonic-net/sonic-buildimage#11996
What I did
Add the ability to the user to save the loglevel and make it persistent to reboot with the support in warm-upgrade. (Not need to add special support for cold/fast reboot since the LOGLEVEL DB flushes during fast/cold reboot).
How I did it
Add a new version to the db_migrator that will move the logger tables from the LOGLEVEL DB to the CONFIG DB
How to verify it
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)