[sfputil] add logic to avoid access none present SFP eeprom #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleveque
approved these changes
Oct 22, 2018
mihirpat1
pushed a commit
to mihirpat1/sonic-utilities
that referenced
this pull request
Sep 15, 2023
* Add lpmode APIs for sff8436 and sff8636 * Update comments * Simplify set_lpmode logic * Update docstring * Update docstring to lpmode on/off
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
When access an SFP eeprom which not presente will cause error print from the kernel modules:
ERR kernel: [41770.216758] mlxsw_minimal 2-0048: Eeprom query failedto avoid this need to prevent from accessing none presence SFP eeprom
- How I did it
before read the SFP eeprom, add logic to determine the presence of SFP with method get_presence()
- How to verify it
run "show interface transceiver eeprom EthernetX" command to verify
- Previous command output (if the output of a command-line utility has changed)
no change for command output
- New command output (if the output of a command-line utility has changed)
no change for command output