Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an on/off knob for BGP EOIU pulling on warm restart #655

Merged
merged 2 commits into from
Nov 7, 2019

Conversation

heidinet2007
Copy link
Contributor

@heidinet2007 heidinet2007 commented Sep 19, 2019

Add a knob to turn on/off the BGP EOIU pulling when BGP warm restart. By default, it's off.
This is to address review comments for sonic-net/sonic-buildimage#2823

Other related PR

sonic-net/sonic-buildimage#3489

sonic-net/sonic-buildimage#2823
sonic-net/sonic-swss-common#273
sonic-net/sonic-swss#856

root@ASW-7001:~# config warm_restart bgp_eoiu true
root@ASW-7001:~# show warm_restart config 
name    enable    timer_name    timer_duration    eoiu_enable
------  --------  ------------  ----------------  -------------
bgp     false     NULL          NULL              true

root@ASW-7001:~# config warm_restart bgp_eoiu false
root@ASW-7001:~# show warm_restart config 
name    enable    timer_name    timer_duration    eoiu_enable
------  --------  ------------  ----------------  -------------
bgp     false     NULL           NULL             false


root@ASW-7001:~# config warm_restart bgp_timer 120
root@ASW-7001:~# show warm_restart config 
name    enable    timer_name      timer_duration  eoiu_enable
------  --------  ------------  ----------------  -------------
bgp     false     bgp_timer     120               false


root@ASW-7001:~# config warm_restart bgp_eoiu true
root@ASW-7001:~# show warm_restart config 
name    enable    timer_name      timer_duration  eoiu_enable
------  --------  ------------  ----------------  -------------
bgp      false    bgp_timer     120               true

@pavel-shirshov pavel-shirshov removed their request for review October 31, 2019 19:51
@pavel-shirshov
Copy link
Contributor

I'm ok if Joe approved it. I'm not an expert in this library

@pavel-shirshov
Copy link
Contributor

retest this please

@yxieca
Copy link
Contributor

yxieca commented Nov 7, 2019

retest this please

@yxieca yxieca merged commit 2c0af8a into sonic-net:master Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants