Cannot create an instance of the abstract type or interface 'ICollection<SomeDto>'

src/Mappee/Configuration/Profile.cs

@@ -49,13 +49,13 @@ private void CreateMappings(Type src, Type dest)
             if (destinationProperty != null)
             {
                 string mapping;
-                if (sourceProperty.PropertyType.IsClass && sourceProperty.PropertyType != typeof(string))
+                if ((sourceProperty.PropertyType.IsClass || sourceProperty.PropertyType.IsAbstract || sourceProperty.PropertyType.IsInterface) && sourceProperty.PropertyType != typeof(string))
                 {
-                    if (sourceProperty.PropertyType.GetInterface(nameof(IEnumerable)) != null)
+                    if (sourceProperty.PropertyType.GetInterface(nameof(IEnumerable)) != null || sourceProperty.PropertyType.GetInterface(nameof(ICollection)) != null)
                     {
                         var genericSourceType = sourceProperty.PropertyType.GetGenericArguments()[0];
                         var genericDestinationType = destinationProperty.PropertyType.GetGenericArguments()[0];
-                        mapping = $"classInstance.{destinationProperty.Name} = new();\r\nsource.{sourceProperty.Name}?.ForEach(x => classInstance.{destinationProperty.Name}.Add(__Mappe_Quick_Mapping.{GenerateMethodName(genericSourceType, genericDestinationType)}(x)));";
+                        mapping = $"classInstance.{destinationProperty.Name} = new List<{genericDestinationType.Namespace}.{genericDestinationType.Name}>();\r\n((List<{genericSourceType.Namespace}.{genericSourceType.Name}>)source.{sourceProperty.Name})?.ForEach(x => classInstance.{destinationProperty.Name}.Add(__Mappe_Quick_Mapping.{GenerateMethodName(genericSourceType, genericDestinationType)}(x)));";
                     }
                     else
                     {

src/Mappee/Mappee.csproj

@@ -1,40 +1,44 @@
 <Project Sdk="Microsoft.NET.Sdk">
-
-  <PropertyGroup>
-    <TargetFrameworks>netstandard2.0;netstandard2.1;net7;net8;net481</TargetFrameworks>
-    <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
-	  <LangVersion>latest</LangVersion>
-	  <GeneratePackageOnBuild>True</GeneratePackageOnBuild>
-	  <Description>Mappee - Fastest avaiable mapper for .NET (AutoMapper / TinyMapper / Mapster / Mapperly alternative)</Description>
-	  <Copyright>https://github.com/sonquer/mappee/blob/main/LICENSE</Copyright>
-	  <PackageProjectUrl>https://github.com/sonquer/mappee</PackageProjectUrl>
-	  <PackageReadmeFile>README.md</PackageReadmeFile>
-	  <RepositoryUrl>https://github.com/sonquer/mappee</RepositoryUrl>
-	  <RepositoryType>git</RepositoryType>
-	  <Authors>Patryk Pasek</Authors>
-	  <AssemblyVersion>0.1.0.0</AssemblyVersion>
-	  <FileVersion>0.1.0.0</FileVersion>
-	  <Version>0.1.0.0-alpha</Version>
-  </PropertyGroup>
-
-  <ItemGroup>
-    <None Include="..\..\README.md">
-      <Pack>True</Pack>
-      <PackagePath>\</PackagePath>
-    </None>
-  </ItemGroup>
-
-  <ItemGroup>
-    <PackageReference Include="Microsoft.CodeAnalysis.CSharp" Version="4.8.0" />
-    <PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="8.0.0" />
-  </ItemGroup>
-
-  <ItemGroup>
-    <Folder Include="Properties\" />
-  </ItemGroup>
-
+	<PropertyGroup>
+		<TargetFrameworks>netstandard2.0;netstandard2.1;net7;net8;net481</TargetFrameworks>
+		<PackageRequireLicenseAcceptance>false</PackageRequireLicenseAcceptance>
+		<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
+		<LangVersion>latest</LangVersion>
+		<GeneratePackageOnBuild>True</GeneratePackageOnBuild>
+		<Description>Mappee - Fastest avaiable mapper for .NET (AutoMapper / TinyMapper / Mapster / Mapperly alternative)</Description>
+		<Copyright>Copyright (c) 2024 Patryk Pasek</Copyright>
+		<PackageLicenseUrl>https://github.com/sonquer/mappee/blob/main/LICENSE</PackageLicenseUrl>
+		<PackageProjectUrl>https://github.com/sonquer/mappee</PackageProjectUrl>
+		<PackageReadmeFile>README.md</PackageReadmeFile>
+		<PackageTags>Mappee;Mapper</PackageTags>
+		<RepositoryUrl>https://github.com/sonquer/mappee</RepositoryUrl>
+		<RepositoryType>git</RepositoryType>
+		<Authors>Patryk Pasek</Authors>
+		<AssemblyVersion>0.1.1.0</AssemblyVersion>
+		<FileVersion>0.1.1.0</FileVersion>
+		<Version>0.1.1.0-alpha</Version>
+		<PackageIcon>icon.jpg</PackageIcon>
+		<PublishRepositoryUrl>true</PublishRepositoryUrl>
+		<EmbedUntrackedSources>true</EmbedUntrackedSources>
+	</PropertyGroup>
 	<ItemGroup>
-		<InternalsVisibleTo Include="Mappee.UnitTests" />
+		<None Include="..\..\README.md">
+			<Pack>True</Pack>
+			<PackagePath>\</PackagePath>
+		</None>
 	</ItemGroup>
-
-</Project>
+	<ItemGroup>
+		<PackageReference Include="Microsoft.CodeAnalysis" Version="4.8.0"/>
+		<PackageReference Include="Microsoft.CodeAnalysis.CSharp" Version="4.8.0"/>
+		<PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="8.0.0"/>
+	</ItemGroup>
+	<ItemGroup>
+		<None Include="Images\icon.jpg" Pack="true" PackagePath="\"/>
+	</ItemGroup>
+	<ItemGroup>
+		<Folder Include="Properties\"/>
+	</ItemGroup>
+	<ItemGroup>
+		<InternalsVisibleTo Include="Mappee.UnitTests"/>
+	</ItemGroup>
+</Project>

src/Tests/Benchmark/Models/Entities/TestObject.cs

@@ -20,7 +20,7 @@ public sealed class TestObject
     public string Nickname { get; set; }
     public short Short { get; set; }
     public List<TestObjectField> Fields { get; set; } = new();
-    public List<TestObjectModification> Modifications { get; set; } = new();
-    public List<TestObjectLink> Links { get; set; } = new();
+    public IEnumerable<TestObjectModification> Modifications { get; set; } = new List<TestObjectModification>();
+    public ICollection<TestObjectLink> Links { get; set; } = new List<TestObjectLink>();
     public TestObject Child { get; set; }
 }

src/Tests/Mappee.UnitTests/Configuration/ProfileTests.cs

@@ -10,7 +10,7 @@ public void Compile_ReturnsCompilationResult_WhenSuccessful()
         {
             var profile = new Profile();
             profile.Map<TestObject, TestObjectDto>();
-            profile.Map<TestObject, TestObjectDto>();
+            profile.Map<TestObjectField, TestObjectFieldDto>();
 
             var result = profile.Compile(compilationResult: true);
 
@@ -25,6 +25,7 @@ public void Compile_ReturnsGeneratedCode_WhenSuccessful()
         {
             var profile = new Profile();
             profile.Map<TestObject, TestObjectDto>();
+            profile.Map<TestObjectField, TestObjectFieldDto>();
 
             var sourceCode = profile.Compile(compilationResult: true);
 
@@ -44,6 +45,8 @@ public void Compile_ReturnsGeneratedCode_WhenSuccessful()
             Assert.Contains("classInstance.Long = source.Long;", sourceCode.GeneratedCode);
             Assert.Contains("classInstance.Nickname = source.Nickname;", sourceCode.GeneratedCode);
             Assert.Contains("classInstance.Short = source.Short;", sourceCode.GeneratedCode);
+            Assert.Contains("classInstance.Fields = new List<Mappee.UnitTests.Models.TestObjectFieldDto>();", sourceCode.GeneratedCode);
+            Assert.Contains("((List<Mappee.UnitTests.Models.TestObjectField>)source.Fields)?.ForEach(x => classInstance.Fields.Add(__Mappe_Quick_Mapping.__Mappee_UnitTests_Models_TestObjectField_to_Mappee_UnitTests_Models_TestObjectFieldDto(x)));", sourceCode.GeneratedCode);
             Assert.Contains("return classInstance;", sourceCode.GeneratedCode);
         }
 
@@ -52,6 +55,7 @@ public void Compile_ReturnsNull_WhenCompilationResultIsFalse()
         {
             var profile = new Profile();
             profile.Map<TestObject, TestObjectDto>();
+            profile.Map<TestObjectField, TestObjectFieldDto>();
 
             var result = profile.Compile(compilationResult: false);
 
@@ -63,6 +67,7 @@ public void Compile_ReturnsGeneratedCodeWithoutOptimization_WhenAggressiveOptimi
         {
             var profile = new Profile();
             profile.Map<TestObject, TestObjectDto>();
+            profile.Map<TestObjectField, TestObjectFieldDto>();
 
             var result = profile.Compile(compilationResult: true, aggressiveOptimization: false);
 
@@ -74,6 +79,7 @@ public void Compile_ReturnsGeneratedCodeWithOptimization_WhenAggressiveOptimizat
         {
             var profile = new Profile();
             profile.Map<TestObject, TestObjectDto>();
+            profile.Map<TestObjectField, TestObjectFieldDto>();
 
             var result = profile.Compile(compilationResult: true, aggressiveOptimization: true);
 

src/Tests/Mappee.UnitTests/Models/TestObject.cs

@@ -16,4 +16,5 @@ public sealed class TestObject
     public long Long { get; set; }
     public string Nickname { get; set; }
     public short Short { get; set; }
+    public ICollection<TestObjectField> Fields { get; set; } = new List<TestObjectField>();
 }

src/Tests/Mappee.UnitTests/Models/TestObjectDto.cs

@@ -16,4 +16,5 @@ public sealed class TestObjectDto
     public long Long { get; set; }
     public string Nickname { get; set; }
     public short Short { get; set; }
+    public List<TestObjectFieldDto> Fields { get; set; } = new();
 }

src/Tests/Mappee.UnitTests/Models/TestObjectField.cs

@@ -0,0 +1,8 @@
+namespace Mappee.UnitTests.Models;
+
+public sealed class TestObjectField
+{
+    public long Id { get; set; }
+
+    public string Name { get; set; }
+}

src/Tests/Mappee.UnitTests/Models/TestObjectFieldDto.cs

@@ -0,0 +1,8 @@
+namespace Mappee.UnitTests.Models;
+
+public sealed class TestObjectFieldDto
+{
+    public long Id { get; set; }
+
+    public string Name { get; set; }
+}