Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature/#841] 마이페이지 compose 리팩토링 #854
[feature/#841] 마이페이지 compose 리팩토링 #854
Changes from 20 commits
b03d14f
07713a9
cdf75aa
ee2778b
fac5ee1
bf9998e
7d98a63
8edbe5a
4c4f66f
3e8ba39
e21ca0f
f008af8
b019008
56e8f78
8133da3
9119127
afb7488
e71fcf6
19794cd
12a0d50
f13250f
1e3b4b4
ab0d1d0
f20195e
ca3b1e9
2b96203
c6239ad
9834a95
96eba0f
eddf9a3
52dbd50
a247848
bdb041a
524029c
1443f05
614f92a
38dbedb
ec770b6
c41961b
8d76b7b
e5e7f87
b40e17b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
Large diffs are not rendered by default.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
onButtonClick
이라는 이름 보다는 개발자에게 익숙한onClick
을 하는건 어떨까요? 클릭되는 부분이 2개 이상이라면 이름을 지어주는게 좋지만, 하나만 있다면 익숙한 이름 네이밍이 사용하기 편할거같아요There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
저는 매개변수를 받을 때 "해당값이 없다면 컴포넌트가 목적에 맞는 형태를 가질 수 없는가?"를 기준으로 옵셔널과 필수를 결정해요. 그렇기 때문에 대부분의 값은 저라면 옵셔널로 할 것 같습니다.
그리고 text라는 value를 받아오기 보다 Composable을 받아오는건 어떨까요? 이 컴포넌트를 호출하는 곳에서 Text에 대한 설정을 해준다면 더욱 재사용성이 좋을 것 같아요