-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature/#875] fortune amulet TodayFortuneCard API #876
base: feature/873
Are you sure you want to change the base?
Conversation
|
state.isLoading -> { | ||
// Loading View | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오버레이 깔고 서클 로딩 인디케이터 도는게 제일 이상적일듯?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
저도 그렇게 생각합니다!
해당 피쳐의 다른 뷰도 비워뒀길래 같이 비워뒀다가 pm/pd에게 건의 후 확정이 된다면 동시에 적용하도록 하겠습니다 :)
paddingValue: PaddingValues, | ||
description: String, | ||
name: String, | ||
imageColor: Color, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
선생님 이게 뭘까요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
imageColor: Color, | |
description: @Composable ColumnScope.() -> Unit |
카드 설명 텍스트를 이렇게 description으로 받아와서 그리는 방법도 있을 것 같아요.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
확장성을 생각한 조언 감사합니다!
반영하도록 할게요 :)
|
||
private fun parseColor(colorCode: String): Color { | ||
val color: Color = try { | ||
Color(android.graphics.Color.parseColor(colorCode)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typealias 써보는건 어떨지?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오호 이건 생각을 못해본 방법이네요!
적용했습니다 :)
navigateToFortuneDetail: (String) -> Unit, | ||
) { | ||
val date = remember { getTodayInfo() } | ||
val date = rememberSaveable { getTodayInfo() } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
val date = rememberSaveable { getTodayInfo() } | |
val date = rememberSaveable { getToday() } |
이건 어떤가요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
좋은거 같습니다!
굳이 Info를 붙일 필요가 없어보이네요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
크게 수정할건 없군요 좋습니다.
What is this issue?
Reference
fortuneAmulet.mp4
X버튼과 "홈으로가기" 버튼의 경우 모듈간 이동이기 때문에 알림관련 연결 후 작업 예정입니다.