Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure blob type header #82

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

meelisd
Copy link

@meelisd meelisd commented Dec 19, 2023

Adds a second set of interceptors that add the x-ms-blob-type header to artifact upload requests to Azure storage when the AZURE_BLOB_URL environment variable is configured.

The CLI complains about not being able to confirm the upload of artifacts but both videos and screenshots are properly uploaded to the storage account and they do show up in our sorry-cypress dashboard. I suspect this has to do with an API endpoint that is not implemented by the sorry-cypress director.

Warning: We encountered an error while confirming the upload of artifacts.

These results will not display artifacts.

This error will not affect or change the exit code.

StatusCodeError: 404 - "<!DOCTYPE html>\n<html lang=\"en\">\n<head>\n<meta charset=\"utf-8\">\n<title>Error</title>\n</head>\n<body>\n<pre>Cannot PUT /instances/e1617adc-01e3-4568-9910-97f8ca1dbbbd/artifacts</pre>\n</body>\n</html>\n"

Tested on Windows 11 with Cypress 13.6.0

@meelisd
Copy link
Author

meelisd commented Dec 19, 2023

I'd like to add tests but after browsing through the existing tests I'm not sure where to start, suggestions are appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant