Fix codegen target paths #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change we would write the ScalaPB-generated code directly to `sourceManaged`. This works fine until another library/app writes to that directory. It seems like ScalaPB deletes all contents in its specified target directory, therefore removing any other code that might also live there. To fix this, we now write the generated code in twinagle-specific subdirectories. By doing that, ScalaPB only cleans our own directories, leaving other subdirs in the main `sourceManaged` directory alone. This change is fully backwards-compatible, no code-changes are needed. You might have to run `sbt clean` once in the target project though to prevent duplicate files.
julioz
approved these changes
Jul 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change we would write the ScalaPB-generated code directly to
sourceManaged. This works fine until another library/app writes tothat directory. It seems like ScalaPB deletes all contents in its
specified target directory, therefore removing any other code that might
also live there.
To fix this, we now write the generated code in twinagle-specific
subdirectories. By doing that, ScalaPB only cleans our own directories,
leaving other subdirs in the main
sourceManageddirectory alone.This change is fully backwards-compatible, no code-changes are needed.
You might have to run
sbt cleanonce in the target project thoughto prevent duplicate files.