CSG Module 2.0 #213
Merged
CSG Module 2.0 #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… rotate_x/y/z and scale_x/y/z in functions.ts.
- Refactored Group class to return a new Group consisting of a shallow copy of its children for every transformation - Removed several functions in functions.ts to simplify the csg module
…() and various renderer funtions.
…on on transformed Boolean operation product' bug
RichDom2185
force-pushed
the
richard/fix-csg-20
branch
from
4e289af
to
120e6b0
Compare
|
Finally after almost 2 hours of interactive rebasing, this PR should be done. @joeng03 I tried to keep the history as much as possible, but I squashed some commits that introduced the unnecessary files in the |
martin-henz
approved these changes
May 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to supersede #206 due to the incorrect merging there. Refer to it for the full description.