Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor toolshed fixes / tweaks #5315

Merged
merged 7 commits into from
Sep 6, 2024

Conversation

ElectroJr
Copy link
Member

  • Ensures that IConError messages don't use markup when they are meant to be using plain text
    • This was preventing toolshed from printing error messages when using array types, as [] is invalid markup.
  • Makes GetParserForType() always cache the returned parser.
    • Currently generating the completion suggestions for something like val EntityUid[] is really slow because it would constantly try to use reflection to recursively get non-existent parsers for all the array interfaces.
    • I'm not sure why it wasn't always being cached before, I assume it was unintentional?
  • Caches the TypeTypeParser completion options

@ElectroJr ElectroJr merged commit be9db26 into space-wizards:master Sep 6, 2024
3 checks passed
@ElectroJr ElectroJr deleted the toolshed-fixes branch September 6, 2024 00:48
@ElectroJr ElectroJr mentioned this pull request Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant