Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add required keyword attributes to sandbox whitelist #5474

Merged
merged 3 commits into from
Sep 30, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion RELEASE-NOTES.md
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ END TEMPLATE-->

### New features

*None yet*
* `RequiredMemberAttribute` and `SetsRequiredMembersAttribute` have been added to the sandbox whitelist. I.e., you can now use the `required` keyword in client/shared code.

### Bugfixes

Expand Down
3 changes: 2 additions & 1 deletion Robust.Shared/ContentPack/Sandbox.yml
Original file line number Diff line number Diff line change
Expand Up @@ -480,6 +480,7 @@ Types:
NotNullAttribute: { All: True }
NotNullIfNotNullAttribute: { All: True }
NotNullWhenAttribute: { All: True }
SetsRequiredMembersAttribute: { All : True}
SuppressMessageAttribute: { All: True }
System.Diagnostics:
DebuggableAttribute: { All: True }
Expand Down Expand Up @@ -588,7 +589,6 @@ Types:
Vector2: { All: True }
Vector3: { All: True }
Vector4: { All: True }
Matrix3x2: { All: True }
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a duplicate entry

System.Reflection:
Assembly:
Methods:
Expand Down Expand Up @@ -653,6 +653,7 @@ Types:
NullableContextAttribute: { All: True }
PreserveBaseOverridesAttribute: { All: True }
RefSafetyRulesAttribute: { All: True }
RequiredMemberAttribute: { All: True }
RuntimeCompatibilityAttribute: { All: True }
RuntimeHelpers: { All: True }
TaskAwaiter: { All: True }
Expand Down
Loading