accept Into<IVec> for Tree operations that provide new values #627
Conversation
|
Hum... It does seem that it will not pass the tests if you do not add a type annotation. |
|
By the way, don't you think it could be "better" to bump to 0.21.5 once #626 is merged? |
|
versions are cheap! |
|
but, now that I realized there's some breakage possibility, I'll bump to 0.22 |
| ) -> Result<std::result::Result<(), Option<IVec>>> | ||
| where | ||
| K: AsRef<[u8]>, | ||
| IVec: From<V>, | ||
| OV: AsRef<[u8]>, | ||
| IVec: From<NV>, |
There was a problem hiding this comment.
Why not NV: Into<IVec>? Just asking, no offense.
There was a problem hiding this comment.
because then below we can't use IVec::from(v), which is cleaner IMO than v.into() or turbofishing it
| ) -> Result<std::result::Result<(), Option<IVec>>> | ||
| where | ||
| K: AsRef<[u8]>, | ||
| OV: AsRef<[u8]>, |
There was a problem hiding this comment.
Don't you remenber that it was not possible the last time I tried? 😄
I do not think that the Rust language team changed that inference behavior, sadly...
There was a problem hiding this comment.
Ok, we will keep these lacks of inference. I prefer that, it is more generic!
There was a problem hiding this comment.
cas is already sort of a rare codepath and today I'm preferring genericism
No description provided.