Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the monitors DB router #1500

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Conversation

york-stsci
Copy link
Collaborator

With the new router, I have specifically tested that:

  • For operations involving monitor tables, migrations generate SQL in the monitors database, and no-ops otherwise
  • For operations not involving monitor tables, migrations generate SQL in the default database, and no-ops in the monitors database.

…e migrations happen only on the monitors database, and only monitor table migrations happen on the monitors database
Copy link
Collaborator

@mfixstsci mfixstsci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @york-stsci let's wait for the CI to wrap up and I will merge it.

@mfixstsci mfixstsci merged commit ec02a52 into spacetelescope:develop Feb 26, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants