Add new NIRISS AMI-related suffixes #1613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @bhilbert4, Thank you for updating ! Cheers ! There are no PEP8 issues in this Pull Request. 🍻 Comment last updated at 2024-07-09 15:01:34 UTC |
|
@mfixstsci this is ready to go. Thinking a bit about the filename parser, do you think it's worth changing it such that when it finds a filename it can't parse, it returns None rather than raising an exception? That would prevent things like the preview image generator or the archive database update from stopping completely when there's one unrecognized file. @BradleySappington |
mfixstsci
approved these changes
Jul 9, 2024
|
@bhilbert4 yeah, its probably worth doing that work, may want to notify us if there is an unrecognized file just so we can adjust? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a few new NIRISS AMI-related filename suffixes to the list of recognized suffix values. These are new data products recently added to pipeline outputs.