Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add erfa and drizzle to devdeps tests #8094

Closed
wants to merge 8 commits into from

Conversation

braingram
Copy link
Collaborator

@braingram braingram commented Nov 27, 2023

The changes in this PR allowed the devdeps job to run with the dev version of numpy (currently 2.1.0.dev0):
https://github.com/spacetelescope/jwst/actions/runs/8513247164/job/23316561517?pr=8094#step:10:285
However, there are a few failures and the run never finished (it stalled after 6 hours).

I see no mention of test_outlier_step_no_outliers in the logs (with pytest run with -v) or any test in test_outlier_detection.py which might suggest something is up with outlier_detection with dev numpy.

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

Copy link

codecov bot commented Nov 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.63%. Comparing base (2fb073e) to head (5d71450).
Report is 18 commits behind head on master.

❗ Current head 5d71450 differs from pull request most recent head 5711acd. Consider uploading reports for the commit 5711acd to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8094      +/-   ##
==========================================
+ Coverage   75.31%   77.63%   +2.32%     
==========================================
  Files         474      451      -23     
  Lines       38965    34529    -4436     
==========================================
- Hits        29345    26808    -2537     
+ Misses       9620     7721    -1899     
Flag Coverage Δ *Carryforward flag
nightly 77.63% <ø> (+0.30%) ⬆️ Carriedforward from bd3c13f

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zacharyburnett zacharyburnett changed the title install dev erfa for devdeps add erfa and drizzle to devdeps tests Apr 2, 2024
@braingram braingram closed this Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation Continuous Integration (CI) and testing automation tools installation outlier_detection run devdeps tests testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant