Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move build configuration from setup.cfg to pyproject.toml #11

Merged
merged 4 commits into from
May 8, 2023

Conversation

zacharyburnett
Copy link
Contributor

setuptools now supports the [project] table, which is defined by PEP621.

Additionally, setuptools now supports its own entry in pyproject.toml called [tool.setuptools] (pypa/setuptools#1688, https://setuptools.pypa.io/en/latest/userguide/pyproject_config.html#setuptools-specific-configuration); however, it comes with the following disclaimer:

Support for declaring configurations not standardized by PEP 621 (i.e. the [tool.setuptools] table), is still in beta stage and might change in future releases.

Reading toml is supported natively in Python 3.11 with tomllib

Given this, we can attempt to consolidate the build configuration into a single pyproject.toml file that can possibly be read by other build systems in the future.

@zacharyburnett zacharyburnett marked this pull request as ready for review April 19, 2023 15:47
@codecov
Copy link

codecov bot commented Apr 19, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.55 🎉

Comparison is base (53eb816) 87.50% compared to head (b545747) 88.05%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #11      +/-   ##
==========================================
+ Coverage   87.50%   88.05%   +0.55%     
==========================================
  Files           9        9              
  Lines         192      201       +9     
==========================================
+ Hits          168      177       +9     
  Misses         24       24              

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@duytnguyendtn duytnguyendtn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Installs and imports nicely on my side. Thanks for the modernization effort!

@kecnry kecnry requested a review from rosteen May 4, 2023 14:15
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
zacharyburnett and others added 2 commits May 4, 2023 10:49
Co-authored-by: Ricky O'Steen <39831871+rosteen@users.noreply.github.com>
Co-authored-by: Ricky O'Steen <39831871+rosteen@users.noreply.github.com>
@kecnry kecnry requested a review from rosteen May 8, 2023 18:05
@kecnry kecnry merged commit 47e7d63 into spacetelescope:main May 8, 2023
@zacharyburnett zacharyburnett deleted the pep621 branch May 8, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants