-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move build configuration from setup.cfg
to pyproject.toml
#11
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #11 +/- ##
==========================================
+ Coverage 87.50% 88.05% +0.55%
==========================================
Files 9 9
Lines 192 201 +9
==========================================
+ Hits 168 177 +9
Misses 24 24 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Installs and imports nicely on my side. Thanks for the modernization effort!
Co-authored-by: Ricky O'Steen <39831871+rosteen@users.noreply.github.com>
Co-authored-by: Ricky O'Steen <39831871+rosteen@users.noreply.github.com>
setuptools
now supports the[project]
table, which is defined by PEP621.Additionally,
setuptools
now supports its own entry inpyproject.toml
called[tool.setuptools]
(pypa/setuptools#1688, https://setuptools.pypa.io/en/latest/userguide/pyproject_config.html#setuptools-specific-configuration); however, it comes with the following disclaimer:Reading
toml
is supported natively in Python 3.11 withtomllib
Given this, we can attempt to consolidate the build configuration into a single
pyproject.toml
file that can possibly be read by other build systems in the future.